fix: Don't register DynamicJobFactory into container

Author: linkdotnet

src/NCronJob/Configuration/NCronJobOptionBuilder.cs

@@ -199,31 +199,7 @@ public INotificationStage<TJob> AddNotificationHandler<TJobNotificationHandler>(
     /// <inheritdoc />
     public INotificationStage<TJob> ExecuteWhen(Action<DependencyBuilder<TJob>>? success = null, Action<DependencyBuilder<TJob>>? faulted = null)
     {
-        if (success is not null)
-        {
-            var dependencyBuilder = new DependencyBuilder<TJob>(services);
-            success(dependencyBuilder);
-            var runWhenSuccess = dependencyBuilder.GetDependentJobOption();
-            runWhenSuccess.ForEach(s =>
-            {
-                services.TryAddSingleton(s);
-                services.TryAddSingleton(s.Type);
-            });
-            jobs.ForEach(j => j.RunWhenSuccess = runWhenSuccess);
-        }
-
-        if (faulted is not null)
-        {
-            var dependencyBuilder = new DependencyBuilder<TJob>(services);
-            faulted(dependencyBuilder);
-            var runWhenFaulted = dependencyBuilder.GetDependentJobOption();
-            runWhenFaulted.ForEach(s =>
-            {
-                services.TryAddSingleton(s);
-                services.TryAddSingleton(s.Type);
-            });
-            jobs.ForEach(j => j.RunWhenFaulted = runWhenFaulted);
-        }
+        ExecuteWhenHelper.AddRegistration(services, jobs, success, faulted);
 
         return this;
     }
@@ -276,31 +252,7 @@ public INotificationStage<TJob> AddNotificationHandler<TJobNotificationHandler>(
     public INotificationStage<TJob> ExecuteWhen(Action<DependencyBuilder<TJob>>? success = null,
         Action<DependencyBuilder<TJob>>? faulted = null)
     {
-        if (success is not null)
-        {
-            var dependencyBuilder = new DependencyBuilder<TJob>(services);
-            success(dependencyBuilder);
-            var runWhenSuccess = dependencyBuilder.GetDependentJobOption();
-            runWhenSuccess.ForEach(s =>
-            {
-                services.TryAddSingleton(s);
-                services.TryAddSingleton(s.Type);
-            });
-            jobs.ForEach(j => j.RunWhenSuccess = runWhenSuccess);
-        }
-
-        if (faulted is not null)
-        {
-            var dependencyBuilder = new DependencyBuilder<TJob>(services);
-            faulted(dependencyBuilder);
-            var runWhenFaulted = dependencyBuilder.GetDependentJobOption();
-            runWhenFaulted.ForEach(s =>
-            {
-                services.TryAddSingleton(s);
-                services.TryAddSingleton(s.Type);
-            });
-            jobs.ForEach(j => j.RunWhenFaulted = runWhenFaulted);
-        }
+        ExecuteWhenHelper.AddRegistration(services, jobs, success, faulted);
 
         return this;
     }
@@ -389,3 +341,43 @@ INotificationStage<TJob> ExecuteWhen(
         Action<DependencyBuilder<TJob>>? success = null,
         Action<DependencyBuilder<TJob>>? faulted = null);
 }
+
+internal static class ExecuteWhenHelper
+{
+    public static void AddRegistration<TJob>(
+        IServiceCollection services,
+        List<JobDefinition> jobs,
+        Action<DependencyBuilder<TJob>>? success,
+        Action<DependencyBuilder<TJob>>? faulted)
+        where TJob : IJob
+    {
+        if (success is not null)
+        {
+            var dependencyBuilder = new DependencyBuilder<TJob>(services);
+            success(dependencyBuilder);
+            var runWhenSuccess = dependencyBuilder.GetDependentJobOption();
+            runWhenSuccess.ForEach(s =>
+            {
+                services.TryAddSingleton(s);
+                if (s.Type != typeof(DynamicJobFactory))
+                {
+                    services.TryAddSingleton(s.Type);
+                }
+            });
+            jobs.ForEach(j => j.RunWhenSuccess = runWhenSuccess);
+        }
+
+        if (faulted is not null)
+        {
+            var dependencyBuilder = new DependencyBuilder<TJob>(services);
+            faulted(dependencyBuilder);
+            var runWhenFaulted = dependencyBuilder.GetDependentJobOption();
+            runWhenFaulted.ForEach(s =>
+            {
+                services.TryAddSingleton(s);
+                services.TryAddSingleton(s.Type);
+            });
+            jobs.ForEach(j => j.RunWhenFaulted = runWhenFaulted);
+        }
+    }
+}