feat: Don't interrupt other jobs when one isn't registered

Author: linkdotnet

CHANGELOG.md

@@ -9,6 +9,7 @@ All notable changes to **NCronJob** will be documented in this file. The project
 ### Changed
 
 - Moved `EnableSecondPrecision` from `AddNCronJob` to `AddCronJob` to allow for more granular control over the precision of the cron expression
+- When a job is not registered, a error is logged, but the execution of other jobs is not interrupted
 
 ## [0.12.0] - 2024-03-22
 

src/LinkDotNet.NCronJob/Scheduler/CronScheduler.LogMessage.cs

@@ -21,4 +21,7 @@ internal sealed partial class CronScheduler
 
     [LoggerMessage(LogLevel.Trace, "End getting next job runs")]
     private partial void LogEndGetNextJobRuns();
+
+    [LoggerMessage(LogLevel.Error, "The type '{Type}' is not registered. Register the service via 'AddCronJob<{Type}>()'.")]
+    private partial void LogJobNotRegistered(Type type);
 }

src/LinkDotNet.NCronJob/Scheduler/CronScheduler.cs

@@ -50,7 +50,11 @@ private void RunActiveJobs(List<Run> runs, CancellationToken stoppingToken)
         foreach (var run in runs)
         {
             var scope = serviceProvider.CreateScope();
-            var job = (IJob)scope.ServiceProvider.GetRequiredService(run.Type);
+            if (scope.ServiceProvider.GetService(run.Type) is not IJob job)
+            {
+                LogJobNotRegistered(run.Type);
+                continue;
+            }
 
             RunJob(run, job, scope, stoppingToken);
         }

tests/NCronJob.Tests/NCronJobIntegrationTests.cs

@@ -199,6 +199,23 @@ public async Task LongRunningJobBlocksSchedulerWithoutIsolationLevelTask()
         jobFinished.ShouldBeFalse();
     }
 
+    [Fact]
+    public async Task NotRegisteredJobShouldNotAbortOtherRuns()
+    {
+        var fakeTimer = TimeProviderFactory.GetTimeProvider();
+        ServiceCollection.AddSingleton<TimeProvider>(fakeTimer);
+        ServiceCollection.AddNCronJob();
+        ServiceCollection.AddCronJob<SimpleJob>(p => p.CronExpression = "* * * * *");
+        await using var provider = ServiceCollection.BuildServiceProvider();
+        provider.GetRequiredService<IInstantJobRegistry>().AddInstantJob<ParameterJob>();
+
+        await provider.GetRequiredService<IHostedService>().StartAsync(CancellationToken);
+
+        fakeTimer.Advance(TimeSpan.FromMinutes(1));
+        var jobFinished = await WaitForJobsOrTimeout(1);
+        jobFinished.ShouldBeTrue();
+    }
+
     private sealed class GuidGenerator
     {
         public Guid NewGuid { get; } = Guid.NewGuid();