-
Notifications
You must be signed in to change notification settings - Fork 4
Frontend component cleanup #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
denniwang
wants to merge
9
commits into
main
Choose a base branch
from
dw-component-cleanup-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create src/ui/ with atoms, molecules, and media folders - Move button, link, subtle-button to src/ui/atoms/ - Move card, select, breadcrumbs, carousel to src/ui/molecules/ - Move audio-player to src/ui/media/ - Add barrel exports for easy importing - Maintain tree-shaking with named exports only
- Create src/features/ with domain-specific folders - Move auth components to src/features/auth/ - Move comment components/contexts to src/features/comments/ - Move document display components to src/features/documents/ - Move edit features to src/features/editor/ - Move audio editing to src/features/audio-edit/ - Move dashboard components to src/features/dashboard/ - Move glossary to src/features/glossary/ - Add barrel exports for each feature domain - Maintain separation of concerns and feature boundaries
- Replace original component files with re-export shims - Maintain existing import paths during migration - Enable gradual import updates without breaking changes - All shims point to new feature/ui locations - TypeScript compilation passes with 0 errors
- Update all page components to import from src/ui for primitives - Update all feature components to import from src/ui for primitives - Maintain existing src/components imports for feature-specific components - Update import paths throughout codebase to use new barrel exports - All imports now follow consistent patterns: - UI primitives: import from 'src/ui' - Feature components: import from 'src/components' (for now) - Cross-feature: import from 'src/features/<name>'
- Remove all re-export shim files from old component locations - Update all remaining imports to use new feature/ui structure - Fix CSS imports to point to correct feature locations - All imports now use consistent src/features/* and src/ui patterns - Zero TypeScript compilation errors - Clean codebase with no temporary migration artifacts
…; introduce layouts/default and update imports across pages; relocate associated css files; fix import paths; typecheck clean
…date all imports and fix related paths; typecheck clean
✅ Deploy Preview for dailp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what the new frontend folder looks like, primarily moved loose components and css.ts files into

uifolder, categorized into atoms, media, molecules, and organisms. no visible performance benefitsNEW
OLD

