Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

project, sample, spectra #1115

Open
tilfischer opened this issue Mar 26, 2024 · 1 comment · May be fixed by #1157
Open

project, sample, spectra #1115

tilfischer opened this issue Mar 26, 2024 · 1 comment · May be fixed by #1157
Assignees
@NRayya
Labels
discussion enhancement greater code or enhancement of existing feature

Comments

@tilfischer
Copy link
Member

Dear all,

Is your enhancement request related to a problem? Please describe.
While it all started with project, study, dataset, the user UI now calls this project, sample, spectra. Being on a project page such as https://nmrxiv.org/P55 and clicking "sample" leads to https://nmrxiv.org/P55?tab=samples and gives and overview of the samples withing this project and a preview of the spectra within each sample. This is headlined with "Studies".

Describe the solution you'd like
I would have expected this page to be headlined with "Samples".

Screenshot 2024-03-26 133414

Best,
Tillmann
@tilfischer tilfischer added the enhancement greater code or enhancement of existing feature label Mar 26, 2024
@NRayya
Copy link
Contributor

NRayya commented Aug 1, 2024

This issue also appears in other places:
Screenshot 2024-08-01 at 12 59 04

@NRayya NRayya self-assigned this Aug 1, 2024
NRayya added a commit that referenced this issue Aug 1, 2024
@NRayya
fix: replace the word "study" with "sample"
cb7ecd5 
fixes  #1115
@NRayya NRayya linked a pull request Aug 1, 2024 that will close this issue
Open
@NRayya NRayya linked a pull request Aug 1, 2024 that will close this issue
fix: replace the word "study" with "sample" #1157
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NRayya NRayya

Labels
discussion enhancement greater code or enhancement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: replace the word "study" with "sample" NFDI4Chem/nmrxiv
2 participants
@NRayya @tilfischer