Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course Picker Images #208

Closed
diogotvf7 opened this issue Mar 5, 2024 · 0 comments · Fixed by #209
Closed

Course Picker Images #208

diogotvf7 opened this issue Mar 5, 2024 · 0 comments · Fixed by #209
Assignees

Comments

@diogotvf7
Copy link
Contributor

What's to be done!

In the states refactor branch branch (#198), a new course picker was built! This greatly improves the UX for users while picking their courses. However, it's current design needed to be improved. For this, our design team created some vector images on Figma that might help to fill the space a bit:

Course picker with no major selected Course picker with no courses selected
2024-03-05-15:38:48 2024-03-05-15:39:37

The placeholders should be either on the left side, right side or both when there is no information to be displayed in the correspondent area. You can see an example here.

Placeholder when no major and no courses selected Placeholder when no courses or no major selected
2024-03-05-15:41:21 2024-03-05-15:41:51

Implementation

The images should be imported as svg for greater quality and added to the svgs folder (src/components/svgs) as a component (see examples in the referred folder). It would also be nice to have classNames as a parameter in order to be easier to apply tailwind to the component.
After this, the only task is to check if there is content being displayed in each, or both, sides of the course picker and display the corresponding image.

OBS: you will have to fork the states refactor branch branch to start working on this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants