Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor optionsList and multipleOptions #222

Closed
tomaspalma opened this issue Jun 18, 2024 · 0 comments · Fixed by #223
Closed

Refactor optionsList and multipleOptions #222

tomaspalma opened this issue Jun 18, 2024 · 0 comments · Fixed by #223
Assignees
@Process-ing

Comments

@tomaspalma
Copy link
Member

image

image

There is redundant information being stored in both states, so we should use only the multipleOptions.

This probably only involves adding the chosen and selected field to the MultipleOptions type and changing the uses of optionsList with multipleOptions.

An example of an annoying bug is, for example, when we change the name of an option, it just updates the optionList in the local storage. This results in a bug since we should also update the multipleOptions structure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Process-ing Process-ing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify multipleOptions and optionsList NIAEFEUP/tts-fe
2 participants
@Process-ing @tomaspalma