Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove openid_client dependency #1246

Open
thePeras opened this issue Jun 23, 2024 · 2 comments
Open

Remove openid_client dependency #1246

thePeras opened this issue Jun 23, 2024 · 2 comments

Comments

@thePeras
Copy link
Member

Remove the dependency and implement the flow by hand.

Originally posted by @thePeras in #1196 (comment)

@LuisDuarte1
Copy link
Member

We should not make the flow by hand. OpenID Connect authentication flow is a bit complex and might be non-trivial to implement. We can search for other packages though.

As I've commented on the PR, this is a non-trivial task, that might have some compromises not only in terms of security but also on implementation time. We should try to find other packages first, and even if we don't find a new replacement, at most, we should fork openid_client for our purposes.

@bartekpacia
Copy link
Collaborator

bartekpacia commented Jun 26, 2024

I'm not at all familiar with OpenID Connect, so can't comment, but @LuisDuarte1's concerns sound valid.

Alternatively, we could fork off openid_client, take very good care of it, and publish that own version to pub.dev. Then NI would maintain a popular, important open-source project in the Flutter world:) stonks

alternatively: message the maintainer of openid_client package and propose to take over maintenance of that package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Product Backlog
Development

No branches or pull requests

3 participants