-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move aai envs from .env to constants file #1262
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1262 +/- ##
=======================================
+ Coverage 16% 16% +1%
=======================================
Files 233 233
Lines 7219 7214 -5
=======================================
Hits 1139 1139
+ Misses 6080 6075 -5 |
What is the purpose of this PR? Why is this being done? Personally, I think these values belong in a .env file or something similar. |
Or maybe I should've put it this way: can the notifications worker not access the .env file? |
@limwa I can explain in the next meeting, but basically in my attempt to load the .env, which was successful, the functions using the environment's variables still doesn't find the DotEnv instantiation. May theory is the package wasn't created for notifications workers. Also, I tried to explore more packages, but no luck. That's why I propose this way, not ideal, but fast, simple and with no security concerns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I tested, everything related to the issue seems to be working fine
Closes #1261