Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix database schema and remove Scrapy scheduler fix #101

Open
LuisDuarte1 opened this issue Jan 26, 2024 · 0 comments · May be fixed by #106
Open

Fix database schema and remove Scrapy scheduler fix #101

LuisDuarte1 opened this issue Jan 26, 2024 · 0 comments · May be fixed by #106

Comments

@LuisDuarte1
Copy link
Member

Per PR #99:

The root cause is that the relation course <--> course_unit is incorrect. It should be a many-to-many relationship instead of a 1-to-many relationship. To quickly fix this without redesigning the schema, we duplicate the course_unit but to a different course (ofc). This causes everything that depends on course units (metadata, schedule) to be duplicated hence the need to disable the deduplication on the scrappy scheduler side.

To disable the scheduler, this PR also bumps Scrappy to 2.7.0, where this feature was added.

This nasty fix should be removed ASAP when we solve the schema issue and use the meta no_filter on course_unit requests instead.

For example, this Course Unit (Mecânica dos Solos) is shared between L.EMG and L.EC (https://sigarra.up.pt/feup/pt/ucurr_geral.ficha_uc_view?pv_ocorrencia_id=519393)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants