Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: don't use a hard-coded date in isPastDate validator #53

Open
BrunoRosendo opened this issue Nov 16, 2022 · 0 comments
Open

tests: don't use a hard-coded date in isPastDate validator #53

BrunoRosendo opened this issue Nov 16, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@BrunoRosendo
Copy link
Member

In the following validator function, we use a hard-coded string with a date in the year "3000" to simulate a date in the future:

params[param] = "01-01-3000" // TODO: use a date in the future instead of hard coded

It would be best to replace this with some logic that takes the current date and adds a day, for example.

PS: This way the tests won't break when we get to 3001 :p

@BrunoRosendo BrunoRosendo added the good first issue Good for newcomers label Nov 16, 2022
@BrunoRosendo BrunoRosendo added this to the Website MVP milestone Nov 16, 2022
@BrunoRosendo BrunoRosendo removed this from the Website MVP milestone Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant