-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin dependencies and add integrity checks #344
Comments
If we pin those dependencies, is there some way to automate updating them so we don't end up with very outdated dependencies one or two years from now? |
The point is to not update them automatically. But this would indeed require some regular maintenance. If you don't think it's worth the effort, that's also fine, but I wanted to point out the risks we currently have. |
I was thinking of automatically creating a pull request to update the version, so we can review if anything is broken. Would something like that be possible without too much effort? |
From this issue, this does not seem to be supported (yet) by dependabot and I haven't found any other tool that can do this, so it looks like we would have to write a tool ourselves if we want automatic pull requests. |
From dependabot/dependabot-core#3228 (comment) it looks like renovate supports it? Or is that a mistake? |
Linked dependencies, as in
<script src="//cdn.jsdelivr.net/npm/docsify/lib/plugins/search.min.js"></script>
don't have a version in their URL, meaning they will always point to the latest version. (Side note: why do these dependencies start with//
instead ofhttps://
?). This has two risks:If you take off the last part of the path of these dependcies (e.g. https://cdn.jsdelivr.net/npm/docsify/lib/plugins/), you can navigate through the versions.
Furthermore, we should use integrity checks to ensure that the loaded code has not been altered with.
The text was updated successfully, but these errors were encountered: