Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated contributing guide + PR template #324

Merged
merged 4 commits into from
Jun 4, 2024
Merged

updated contributing guide + PR template #324

merged 4 commits into from
Jun 4, 2024

Conversation

egpbos
Copy link
Member

@egpbos egpbos commented Dec 14, 2023

This PR introduces some changes to the Guide's contribution guide. Open to feedback!

  • The scope has been made a more explicit, not only listing what should go in, but also what shouldn't.
  • We stole the Blog's idea of having an Editorial Board.
  • The pull request template has been made more explicit to make sure that key points of the guidelines are not forgotten.

c-martinez
c-martinez reviewed Jan 9, 2024
View reviewed changes
Copy link
Member

@c-martinez c-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of comments for your consideration.

.github/PULL_REQUEST_TEMPLATE Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
egpbos
egpbos commented Jan 10, 2024
View reviewed changes
CONTRIBUTING.md Show resolved Hide resolved
egpbos
egpbos commented Jan 10, 2024
View reviewed changes
.github/PULL_REQUEST_TEMPLATE Outdated Show resolved Hide resolved
LourensVeen
LourensVeen reviewed Jan 10, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@lyashevska
Copy link
Member

Looks good. Nice comments by others.

PabRod
PabRod reviewed Jan 19, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
PabRod and others added 2 commits January 19, 2024 11:38
@PabRod
Fix Carlos' surname
69c9b61
@egpbos
process final review comments
f1b76d8 
From the GitHub thread and from Tom Bakker via mail.
@egpbos
Copy link
Member Author

egpbos commented May 30, 2024

@bouweandela @c-martinez I processed all review comments. I think this is good to be merged. Can one of you approve?

@egpbos egpbos merged commit 484ebc7 into NLeSC:main Jun 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabRod PabRod PabRod left review comments

@LourensVeen LourensVeen LourensVeen left review comments

@c-martinez c-martinez c-martinez approved these changes

@bouweandela bouweandela Awaiting requested review from bouweandela

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@egpbos @lyashevska @bouweandela @PabRod @c-martinez @LourensVeen