Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to test on MineRL? #25

Open
ZHZisZZ opened this issue Jun 25, 2023 · 9 comments
Open

Any plan to test on MineRL? #25

ZHZisZZ opened this issue Jun 25, 2023 · 9 comments

Comments

@ZHZisZZ
Copy link

ZHZisZZ commented Jun 25, 2023

Thanks for your great contribution to this reimplementation. Is there any plan to test this implementation on MineRL? Also is there any plan to release the results of crafter and memory-maze compared with the JAX version?

@NM512
Copy link
Owner

NM512 commented Jun 25, 2023

Thanks for asking.
Unfortunately, I don't have the machine capable to run model size XL which is needed for testing MineRL and Crafter.
If someone can run the test on these environments instead, I will implement the code for MineRL environment.

@ZHZisZZ
Copy link
Author

ZHZisZZ commented Jun 25, 2023

I am willing to help. I can run the test and do some preliminary experiments. I can also contribute to the implementation (let me know if needed) although I can not guarantee when I'll finish.

@NM512
Copy link
Owner

NM512 commented Jun 25, 2023

Thanks a lot!
Could you confirm that your machine is capable of running the model size XL first by running the following line.
Please freely ask me if you are stuck at setup of this repo.

python3 dreamer.py --configs crafter --logdir ./logdir/crafter

You might see the error of lacking GPU memory.

@ZHZisZZ
Copy link
Author

ZHZisZZ commented Jun 25, 2023

Sure. I will have a try by early next week.

@zdx3578
Copy link
Contributor

zdx3578 commented Jun 26, 2023

image

@ZHZisZZ
Copy link
Author

ZHZisZZ commented Jun 28, 2023

Thanks a lot! Could you confirm that your machine is capable of running the model size XL first by running the following line. Please freely ask me if you are stuck at setup of this repo.

python3 dreamer.py --configs crafter --logdir ./logdir/crafter

You might see the error of lacking GPU memory.

I have no problem running XL on my GPU.

@NM512
Copy link
Owner

NM512 commented Jun 28, 2023

@ZHZisZZ
Thank you so much!
Could you wait until I prepare the code for MineRL?
I guess it doesn't take so much time.

@NM512
Copy link
Owner

NM512 commented Jun 28, 2023

@zdx3578
Can you help us test benchmarks?

@NM512
Copy link
Owner

NM512 commented Jul 23, 2023

@ZHZisZZ

Hello,

Apologies for the delay in my update.
I've successfully prepared a prototype of the Minecraft environment. Additionally, to address the issue of time-consuming environmental steps using only a single core, I have introduced a parallelization.

I'll now focus on refining the environment further, so I kindly ask for your patience while I work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants