New executable for NOAA gfs_wave_post workflow

[dkokron]

I modified the existing ww3_outp.ftn code and build process to create a new executable for use in the NOAA gfs_wave_post workflow. Instead of parallelizing the report generation and taking 768 processes (three nodes) over 15 minutes, the new executable (ww3_outp2) does the job in under three minutes using a single core.
What is the process for getting these changes into WW3 so that NOAA can use them?

[MatthewMasarik-NOAA]

Hi @dkokron. Great, that's sounds like a massive improvement. This would involve committing to a branch that is already in operations, and I don't know what that full process entails. @JessicaMeixner-NOAA are you able to advise?

[JessicaMeixner-NOAA]

@dkokron That's amazing! Can you start by sharing your WW3 code and your g-w updates with us for testing on our end?

[JessicaMeixner-NOAA]

FYI @AliS-Noaa as you were working on similar things

[dkokron]

What does g-w stand for?

[JessicaMeixner-NOAA]

g-w is global-workflow: https://github.com/noAA-EMC/global-workflow

[dkokron]

Does you team have access to acorn?

[JessicaMeixner-NOAA]

Yes, I have access to acorn, but I prefer if you can share code via github.

[dkokron]

I'm a rusty on git collaboration. Here is my understanding. I need to fork WW3 in github, clone my fork to acorn, branch master/main develop, update my branch, push my branch back to my fork then submit a PR. Did I get that right?

[JessicaMeixner-NOAA]

I don't see that any files have changes? I don't know if it's a permissions issue or something else?

[dkokron]

I'm in the middle of cloning stuff. Look in the WW3.orig directory

[dkokron]

Here is the list of changes under WW3.orig. I'll port these to my fork/clone then test using the case I have on acorn.

HEAD detached at 6dc6c39
Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git restore ..." to discard changes in working directory)
modified: model/bin/make_makefile.sh
modified: model/bin/w3_automake
modified: model/bin/w3_make
modified: model/bin/w3_source
modified: model/esmf/Makefile
modified: model/ftn/w3bullmd.ftn
modified: model/ftn/w3iogrmd.ftn
modified: model/ftn/w3iopomd.ftn

Untracked files:
(use "git add ..." to include in what will be committed)
WW3_INSTALL/
exec/
model/esmf/build.sh
model/esmf/gmake.log
model/ftn/ww3_outp.ftn.dkokron
model/ftn/ww3_outp2.ftn

[dkokron]

Should I start from branch production/GFS.v16?

[JessicaMeixner-NOAA]

Should I start from branch production/GFS.v16?

If our goal is to get this into v16, then yes. We'll have to update and port things to the new code for v17, but first we can just look at things for v16 as I'm assuming the idea is to get this fix in sooner than later.

[dkokron]

I just tested this branch using the gfs_wave_post case. Everything appears to be fine.
https://github.com/dkokron/WW3/tree/dkokron/gfs_wave_post

Let me know if I need to change anything.

[dkokron]

The new ww3_outp2 executable takes one command line argument which is the prefix for the output files (currently "gfswave"). The scripting creates the ww3_outp.inp input file on-the-fly. You can still use the original scripting and executable by changing line 348 of /lfs/h1/hpc/support/daniel.kokron/Projects/gfs_wave_post_bndpntbll/gfs.v16.3.8/scripts/exgfs_wave_post_pnt.sh
from
if true; then
to
if false; then

[dkokron]

I have a bug in my exgfs_wave_post_pnt.sh. I don't expect fixing it will change the overall approach. I'll let you know when it's fixed.

[dkokron]

Just pushed some changes to my github branch. I also modified my copy of gfs.v16.3.8/scripts/exgfs_wave_post_pnt.sh on acorn. I tested modifications using the case I have on-hand. I found no differences.

[dkokron]

I will be on PTO, without access to NOAA systems, starting tonight and ending 12 Oct.

[JessicaMeixner-NOAA]

Thanks for letting us know. Hopefully we'll have had time to review and test everything on our end by the time you return from leave. Hope you enjoy your time away!

[dkokron]

Has there been any movement on this discussion?

[JessicaMeixner-NOAA]

No apologies - I have not had a chance to look at this and we did not have other available resources from others on the team.

[dkokron]

Please let me know if there is any further testing needed.

FYI, the new executable has limited functionality compared with the ww3_outp it is based on. The other functionality is not tested and likely broken in the new executable.

[JessicaMeixner-NOAA]

Thanks for the heads up on this. We would like to test this on our end as well to investigate further but have not quite got a chance.