Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wave scattering in sea ice incorrectly coded for IS1 option #1305

Open
cmbitz opened this issue Oct 2, 2024 · 0 comments
Open

Wave scattering in sea ice incorrectly coded for IS1 option #1305

cmbitz opened this issue Oct 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@cmbitz
Copy link
Collaborator

cmbitz commented Oct 2, 2024

Describe the bug
The IS1 option calls a subroutine that returns a source term VSIR, but VSIR is never used. It does not return a "diagonal" term VDIR, though VDIR would be correctly used if it had. The relevant code is

    CALL W3SIS1 ( SPEC, ICE, VSIR )
    ATT=ATT*EXP(ICE*VDIR(IS)*DTG)

To Reproduce
Do a run where W3_IS1 is defined and compare it to a run without defining W3_IS1. The output will be bit-for-bit the same.

Expected behavior
What should happen is that IS1 scattering dampens wave energy in the sea ice.

Screenshots
N/A

Additional context
I haven't tried to fix this, but I know how to do it. I'm not interested in using this option myself. However, I think some people do use IS1, and may not realize it does nothing. I'd like to also mention this bug is unrelated to the other issue (#1294) that we have about numerical solutions involving sea ice. #1294 is not a bug, but rather a recommendation to improve the numerics. This is plainly a bug. I'd be happy to provide a pull request with this fix combined with correction to the numerics that I am recommending in issue #1294

@cmbitz cmbitz added the bug Something isn't working label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant