Skip to content

Fix replacement filters default value and ensure plain dict conversion #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix replacement filters default value and ensure plain dict conversion #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8de88bc
Initial plan
Copilot Jan 8, 2026
2b20fb6
Fix replacement filters: change default to [] and convert to plain dicts
Copilot Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions src/jcb/renderer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,28 @@ def get_nested_dict(nested_dict, keys):
# --------------------------------------------------------------------------------------------------


def to_plain_dict(obj):
"""
Recursively convert any dict-like object (e.g., wxflow attrdict) to a plain dict.
Also handles lists containing dicts.

Args:
obj: Object to convert (dict, list, or other)

Returns:
Plain Python dict, list, or the original object if neither
"""
if isinstance(obj, dict):
return {k: to_plain_dict(v) for k, v in obj.items()}
elif isinstance(obj, list):
return [to_plain_dict(item) for item in obj]
else:
return obj


# --------------------------------------------------------------------------------------------------


class Renderer():

"""
Expand Down Expand Up @@ -257,8 +279,10 @@ def render(self, algorithm):
# Get list of observations that have their filters replaced
obs_to_replace = replace_obs_filters_dict['observations']

# New filter dictionary
new_filters = replace_obs_filters_dict.get('override_filters', {})
# New filter list (default to empty list, not dict)
new_filters = replace_obs_filters_dict.get('override_filters', [])
# Convert to plain dicts to avoid wxflow attrdict issues
new_filters = to_plain_dict(new_filters)

# Loop over the observers and replace filters for matching observations
for observer, obs_name in zip(observers, obs_names):
Expand Down