Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3pt] Add new arg for code version #1407

Open
RobHanna-NOAA opened this issue Jan 21, 2025 · 2 comments · May be fixed by #1426
Open

[3pt] Add new arg for code version #1407

RobHanna-NOAA opened this issue Jan 21, 2025 · 2 comments · May be fixed by #1426
Assignees
Labels
CatFIM NWS Flood Categorical HAND FIM Med Priority

Comments

@RobHanna-NOAA
Copy link
Contributor

RobHanna-NOAA commented Jan 21, 2025

Can we add a new mandatory argument to CatFIM which askes for the code version we are running. Note.. not the hand version behind it, but the FIM code version. The format will be something like "CatFIM 2.2" or "CatFIM 2_2" (tbd). We need to add this as a new column to all output files (sites, library for SB and FB). This is a Derek request and other tools are going to pick up similar tools. Let's call this field "catfim_version". Also.. let's rename the "version" field, to "hand_version".

@CarsonPruitt-NOAA
Copy link
Collaborator

Will we always know at the time of running the CatFIM code what the final FIM version will be?

@RobHanna-NOAA
Copy link
Contributor Author

Yes. Derek asked for a new "product" code version. When we build hand, we know it is 4.5.11.1 and put it in a field in the catfim outputs called "version". We need to rename this to hand_version. Then he wanted as new peice of data saying what code version of Catfim was used, ie) 2.2. When we load it into HV, we load the "public" version of FIM 5.1 (or whatever). Not sure when/how we will use this in the HV UI, but it is a quick add to our CatFIM code to open up that option. He asked for the same thing for probabilty/LoFi. Likely starting at something like 1.0 or something. So.. yes.. a third "version:" field but only for CatFIM and Probability. The output folders for HAND give that to use automatically. ie) HAND_4_5_11_1.

@RobHanna-NOAA RobHanna-NOAA self-assigned this Feb 7, 2025
@RobHanna-NOAA RobHanna-NOAA linked a pull request Feb 9, 2025 that will close this issue
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CatFIM NWS Flood Categorical HAND FIM Med Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants