Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8pt] Add lake masking to stage-based CatFIM processing #1358

Open
EmilyDeardorff opened this issue Dec 4, 2024 · 2 comments · May be fixed by #1418
Open

[8pt] Add lake masking to stage-based CatFIM processing #1358

EmilyDeardorff opened this issue Dec 4, 2024 · 2 comments · May be fixed by #1418
Assignees
Labels
bug Something isn't working CatFIM NWS Flood Categorical HAND FIM

Comments

@EmilyDeardorff
Copy link
Contributor

Stage-based CatFIM does not currently use any lake masking. This results in it inundating areas that we know are water bodies, which could be misleading.

Update stage-based CatFIM so that it masks out and doesn't inundate areas that are known waterbodies.

Example of stage-based CatFIM at site owsn6 inundating a lake in upstate NY:
image

@EmilyDeardorff EmilyDeardorff added bug Something isn't working CatFIM NWS Flood Categorical HAND FIM labels Dec 4, 2024
@EmilyDeardorff EmilyDeardorff linked a pull request Jan 31, 2025 that will close this issue
20 tasks
@EmilyDeardorff
Copy link
Contributor Author

Developing the method to remove lakes from stage-based CatFIM

The goal of this task is to remove inaccurate CatFIM inundation in and around lakes.
This issue is clearly showed in the example site auon6:

Image

Initially, I tried just masking out the lake polygons after the inundation layers were created.
However, this still left false inundation around the lake shores:

Image

Next, I tried just filtering out the stream segments that have a LakeID associated with them, so those segments just are not inundated.
This improved the result, but there was still a section of the lake that was wrongfully inundated:

Image

The best answer was to combine these methods. By filtering out the HydroIDs that have an associated LakeID, we refrain from inundating most of the stream segments associated with the lake. And then masking out the lakes at the end cleans up any last sections where the lake still might have gotten inundated.
Here is the final result:

Image

@EmilyDeardorff EmilyDeardorff self-assigned this Feb 1, 2025
@EmilyDeardorff
Copy link
Contributor Author

Additional testing of lake masking

I ran stage-based CatFIM with and without the lake masking update for a few different sites.

Lake masking worked exactly as we were hoping in site rudc2.

Image

Image
Image

There is extensive inundation in site dibt2 in Texas. Masking the lake out, while it makes sense, does create a weird looking hole in the inundation.

Image
Image

Lake masking worked as expected in site pgmc2. It's a bit tricky to see because the lake is on the far right of the CatFIM polygons, but the CatFIM is trimmed right where the lake starts.

Image
Image

Site stpm5: This is a funny example! In the current live version of CatFIM, this area had much more inundation and thus needed lake masking. But in our dev version of CatFIM, the inundation is much smaller so the lake doesn't even need to be masked out.

Image

Image

@EmilyDeardorff EmilyDeardorff linked a pull request Feb 6, 2025 that will close this issue
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CatFIM NWS Flood Categorical HAND FIM
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant