Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal ET capability #562

Closed
mattw-nws opened this issue Jul 6, 2023 · 1 comment · Fixed by #599
Closed

Remove internal ET capability #562

mattw-nws opened this issue Jul 6, 2023 · 1 comment · Fixed by #599

Comments

@mattw-nws
Copy link
Contributor

mattw-nws commented Jul 6, 2023

Key stakeholders have indicated that ET calculation should not be a framework capability, there is a BMI module that serves this purpose, and use of the internal ET calc method is actively discouraged. The requirement to continue to support it for legacy purposes is causing unnecessary zombie code to creep into major architectural features like #497, increasing complexity and reducing maintainability. This is a roadmap issue to discuss removing the internal ET support in a near-future breaking change.

Current behavior

ET calculation is a 1st-class feature provided to models including legacy and BMI modules, including significant pipelining code within BMI formulations.

Expected behavior

ET calc code and the pipelining is removed from the architecture.

Steps to replicate behavior (include URLs)

Screenshots

@mattw-nws
Copy link
Contributor Author

See also outstanding #352 and #276 , which would be rendered moot if we cut this capability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant