Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make simulation time parameters available via model_params #639

Open
mattw-nws opened this issue Sep 15, 2023 · 1 comment
Open

Make simulation time parameters available via model_params #639

mattw-nws opened this issue Sep 15, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@mattw-nws
Copy link
Contributor

mattw-nws commented Sep 15, 2023

The simulation start date/time should be made available to running modules, e.g. if a model uses the date or time to compute solar inclination (as Noah-OWP-Modular does--presently it has its own simulation start time in its init config files used for this purpose, and these may disagree). Useful values to make available would probably be:

  • simulation_start_epoch
  • simulation_timestep
  • simulation_start_ordinal_day (1-366)
  • simulation_end_epoch (because why not? Or YAGNI?)

Similar to #588, these should probably be specified like this:

{"source":"simulation_time"`, "from": "simulation_timestep"}

Names and "source" name open for discussion.

Current behavior

Expected behavior

Steps to replicate behavior (include URLs)

Screenshots

@PhilMiller
Copy link
Contributor

Given simulation_start_epoch, why can't the rare model that needs simulation_start_ordinal_day calculate it internally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants