Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tidal harmonic handling #3

Open
jpolton opened this issue Mar 25, 2019 · 9 comments
Open

Update tidal harmonic handling #3

jpolton opened this issue Mar 25, 2019 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@jpolton
Copy link
Contributor

jpolton commented Mar 25, 2019

Add Nico's updated treatment of harmonic analysis with restarts and FES2014 capabilities and extended species set.

@jpolton
Copy link
Contributor Author

jpolton commented Mar 25, 2019

First cut at updating MY_SRC and namelist_cfg options: 335f36d
(Forgot to add this Issue number into the commit)

jpolton added a commit that referenced this issue Mar 25, 2019
@jpolton
Copy link
Contributor Author

jpolton commented Mar 25, 2019

A problem with O1amp_ssh being missing or something. Added _ssh to the field and file definitions for O1 and resubmitted. See if that sorts it. Pending. 55b991a

@jpolton
Copy link
Contributor Author

jpolton commented Mar 25, 2019

Fix variable labels for SSH harmonics ??amp_ssh, ??pha_ssh: 3d733f2

@jpolton
Copy link
Contributor Author

jpolton commented Mar 25, 2019

This worked! Need to replicate for u and v harmonics.

@jdha jdha added the enhancement New feature or request label Mar 26, 2019
@jpolton
Copy link
Contributor Author

jpolton commented Mar 26, 2019

This is pretty much there I think. Just testing except the ARCHER queue is taking hours...
686bfa0

@jpolton
Copy link
Contributor Author

jpolton commented Mar 27, 2019

This works. Well I've tested it for M2 and O1 and it worked. I am inclined to stop unless it is going to be pulled. e2dea92

@jpolton jpolton closed this as completed Mar 27, 2019
@jdha
Copy link
Contributor

jdha commented Mar 27, 2019

So do you want to merge this back into the Master? .... or shall I ;)

@jpolton
Copy link
Contributor Author

jpolton commented Mar 27, 2019

Curiosity got the better of me. Tried with long harmonics for 10 days:
! Long Period Tides
tname(1) = 'SA'
tname(2) = 'SSA'
tname(3) = 'MM'
tname(4) = 'MF'
tname(5) = 'MTM'
tname(6) = 'MSF'
tname(7) = 'MSQM'
It didn't crash, but didn't output either. I should ask Nico if this is expected...

@jpolton jpolton reopened this Mar 27, 2019
@jpolton
Copy link
Contributor Author

jpolton commented Mar 27, 2019

So do you want to merge this back into the Master? .... or shall I ;)

I closed this too early...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants