-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Right now padded evaluation methods are in a bit of a state. That of the node is in common (in a separate trait than unpadded evaluation, even though both traits are always used in conjunction). That of the model is in the ProveModel trait within the prover crate. As a consequence, even though we have compatibility examples of unpadded inference and TF Lite in common, we can't do the same for padded inference (indeed, previously existing code that did just that is commented out).
Let's decide where to put things (I'm inclining towards bringing the padded evaluation method to common, right beside unpadded evaluation; perhaps also merging the two node traits therein; but in any case I haven't thought any of it through) and, crucially, re-introduce padded compatibility examples.