Summary
There are two logging-related packages with confusing names:
- `internal/logger/` - Application logging (zerolog wrapper)
- `internal/logging/` - MCP server-to-client logging
Current State
```
internal/
├── logger/
│ └── logger.go # App logging with zerolog
└── logging/
├── logging.go # MCP notifications
└── logging_test.go
```
Problem
- Names are too similar, causing confusion
- `logger.go` has dead code (`GetUvicornLogConfig` is Python-specific)
- Inconsistent usage patterns across codebase
Expected Outcome
Option A: Rename for clarity
```
internal/
├── applog/ # Renamed from logger
│ └── applog.go
└── mcplog/ # Renamed from logging
├── mcplog.go
└── mcplog_test.go
```
Option B: Merge into single package
```
internal/
└── log/
├── app.go # Application logging
├── mcp.go # MCP notifications
└── mcp_test.go
```
Additional Cleanup
- Remove `GetUvicornLogConfig` - Python-specific dead code
- Standardize logging patterns across codebase
- Add structured logging fields consistently
Acceptance Criteria
Summary
There are two logging-related packages with confusing names:
Current State
```
internal/
├── logger/
│ └── logger.go # App logging with zerolog
└── logging/
├── logging.go # MCP notifications
└── logging_test.go
```
Problem
Expected Outcome
Option A: Rename for clarity
```
internal/
├── applog/ # Renamed from logger
│ └── applog.go
└── mcplog/ # Renamed from logging
├── mcplog.go
└── mcplog_test.go
```
Option B: Merge into single package
```
internal/
└── log/
├── app.go # Application logging
├── mcp.go # MCP notifications
└── mcp_test.go
```
Additional Cleanup
Acceptance Criteria