Replace error-check with unit tests. Allow PV w/ MaxPowerOutput=0 to run successfully.

Author: shorowit

HPXMLtoOpenStudio/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.1</schema_version>
   <name>hpxm_lto_openstudio</name>
   <uid>b1543b30-9465-45ff-ba04-1d1f85e763bc</uid>
-  <version_id>5ca1d59c-7e04-4173-a237-344775b19e8b</version_id>
-  <version_modified>2025-02-17T23:51:11Z</version_modified>
+  <version_id>9cdacdbb-7289-4d0f-a517-3922cf3a30fa</version_id>
+  <version_modified>2025-02-18T17:48:09Z</version_modified>
   <xml_checksum>D8922A73</xml_checksum>
   <class_name>HPXMLtoOpenStudio</class_name>
   <display_name>HPXML to OpenStudio Translator</display_name>
@@ -465,7 +465,7 @@
       <filename>pv.rb</filename>
       <filetype>rb</filetype>
       <usage_type>resource</usage_type>
-      <checksum>9D9BD68D</checksum>
+      <checksum>C2C1C9BA</checksum>
     </file>
     <file>
       <filename>schedule_files/README.md</filename>

HPXMLtoOpenStudio/resources/pv.rb

@@ -37,6 +37,7 @@ def self.apply_pv_system(model, hpxml_bldg, pv_system)
 
     # Apply unit multiplier
     max_power = pv_system.max_power_output * unit_multiplier
+    return if max_power <= 0
 
     if pv_system.is_shared_system
       # Apportion to single dwelling unit by # bedrooms

ReportSimulationOutput/measure.rb

@@ -1433,20 +1433,6 @@ def check_for_errors(runner)
       return false
     end
 
-    # Check total vs net energy use
-    has_pv = @hpxml_bldgs.count { |hpxml_bldg| !hpxml_bldg.pv_systems.empty? } > 0
-    if has_pv
-      if @totals[TE::Total].annual_output == @totals[TE::Net].annual_output
-        runner.registerError('Building has PV but total/net energy uses are equal.')
-        return false
-      end
-    else
-      if @totals[TE::Total].annual_output != @totals[TE::Net].annual_output
-        runner.registerError('Building does not have PV but total/net energy uses are different.')
-        return false
-      end
-    end
-
     # Check sum of electricity produced end use outputs match total output from meter
     sum_elec_prod_annual = @end_uses.select { |k, eu| k[0] == FT::Elec && eu.is_negative }.map { |_k, eu| eu.annual_output.to_f }.sum(0.0) # Negative value
     if (sum_elec_prod_annual - meter_elec_produced).abs > tol

ReportSimulationOutput/measure.xml

@@ -3,8 +3,8 @@
   <schema_version>3.1</schema_version>
   <name>report_simulation_output</name>
   <uid>df9d170c-c21a-4130-866d-0d46b06073fd</uid>
-  <version_id>a82d29da-4213-4138-874d-153fecede29b</version_id>
-  <version_modified>2025-02-18T15:37:37Z</version_modified>
+  <version_id>8b5a1812-c7f9-4efd-b090-2fe0d74f0bcb</version_id>
+  <version_modified>2025-02-18T17:50:35Z</version_modified>
   <xml_checksum>9BF1E6AC</xml_checksum>
   <class_name>ReportSimulationOutput</class_name>
   <display_name>HPXML Simulation Output Report</display_name>
@@ -1972,13 +1972,13 @@
       <filename>measure.rb</filename>
       <filetype>rb</filetype>
       <usage_type>script</usage_type>
-      <checksum>5184BE90</checksum>
+      <checksum>8BAA16E7</checksum>
     </file>
     <file>
       <filename>test_report_sim_output.rb</filename>
       <filetype>rb</filetype>
       <usage_type>test</usage_type>
-      <checksum>E47AF447</checksum>
+      <checksum>97D742B1</checksum>
     </file>
   </files>
 </measure>

ReportSimulationOutput/tests/test_report_sim_output.rb

@@ -629,6 +629,11 @@ def test_annual_only
     actual_fridge_energy_use = actual_annual_rows["End Use: #{FT::Elec}: #{EUT::Refrigerator} (MBtu)"]
     rated_fridge_energy_use = UnitConversions.convert(hpxml.buildings[0].refrigerators[0].rated_annual_kwh, 'kWh', 'MBtu')
     assert_in_epsilon(0.93, actual_fridge_energy_use / rated_fridge_energy_use, 0.1)
+
+    # Verify Total/Net outputs when no PV
+    actual_annual_rows = _get_annual_values(annual_csv)
+    assert_equal(actual_annual_rows["Energy Use: #{TE::Total} (MBtu)"], actual_annual_rows["Energy Use: #{TE::Net} (MBtu)"])
+    assert_equal(actual_annual_rows["Fuel Use: #{FT::Elec}: #{TE::Total} (MBtu)"], actual_annual_rows["Fuel Use: #{FT::Elec}: #{TE::Net} (MBtu)"])
   end
 
   def test_annual_only2
@@ -702,6 +707,10 @@ def test_timeseries_hourly_total_energy
     assert_equal(1, _check_for_constant_timeseries_step(timeseries_cols[0]))
     _check_for_nonzero_avg_timeseries_value(timeseries_csv, ["Energy Use: #{TE::Total}",
                                                              "Energy Use: #{TE::Net}"])
+    # Verify Total/Net outputs when PV
+    actual_annual_rows = _get_annual_values(annual_csv)
+    assert_operator(actual_annual_rows["Energy Use: #{TE::Total} (MBtu)"], :>, actual_annual_rows["Energy Use: #{TE::Net} (MBtu)"])
+    assert_operator(actual_annual_rows["Fuel Use: #{FT::Elec}: #{TE::Total} (MBtu)"], :>, actual_annual_rows["Fuel Use: #{FT::Elec}: #{TE::Net} (MBtu)"])
   end
 
   def test_timeseries_hourly_fuels