Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect code generation for a specific parser graph #17

Open
rajkiranjoshi opened this issue Sep 11, 2020 · 0 comments
Open

Incorrect code generation for a specific parser graph #17

rajkiranjoshi opened this issue Sep 11, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@rajkiranjoshi
Copy link
Collaborator

The generated Wireshark plugin code is incorrect for the perc1 header. Also, possible issues with generated Scapy code for the guess_payload_class() function of the perc1 header. The expected next hop is based on the ACK field and later on the BOS field. This is sort of a multi-field transition but not expressed so by the P4 programmer. Common programmer expectation is to base the transitions between the PERC header based only on the BOS field. The ACK field check is only for other dataplane processing purposes.

Result: Wireshark doesn't parse the packet beyond perc1 header.

Attachments in zip:

  1. perc.p4: source P4 program
  2. perc_parser.pdf: parser graph for the P4 program
  3. perc_sample.pcap: sample pcap file contain PERC packets

perc_issue.zip

@rhl-bthr rhl-bthr added the bug Something isn't working label Sep 29, 2020
@rhl-bthr rhl-bthr self-assigned this Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants