Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency in graph structure #33

Open
rhl-bthr opened this issue Sep 29, 2020 · 1 comment
Open

Inconsistency in graph structure #33

rhl-bthr opened this issue Sep 29, 2020 · 1 comment

Comments

@rhl-bthr
Copy link
Collaborator

rhl-bthr commented Sep 29, 2020 •
edited
Loading

Index 1 of an edge in the graph is of type List. See common.py#L111, but is replaced with a string in some cases in GenTrafficScapy.py#L357

Incidentally, this does not generate a bug, since the cases in which it is replaced with a string - it is interpreted as a string later on, and as a List otherwise.

Not a good practice. Is this worth fixing @rajkiranjoshi ?
@rajkiranjoshi
Copy link
Collaborator

Definitely worth fixing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rajkiranjoshi @rhl-bthr