Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heritability added incorrectly #13

Open
RossDeVito opened this issue Jun 24, 2024 · 3 comments
Open

Heritability added incorrectly #13

RossDeVito opened this issue Jun 24, 2024 · 3 comments

Comments

@RossDeVito
Copy link

In the paper and implementation you add noise to the genetic component of the phenotype to reach a desired heritability using:

g' = h * g + sqrt(1-h^2) N(0, 1), where h = heritability

There may have been confusion due to heritability typically being written as h^2, but the correct equation should be:

g' = sqrt(h^2) * g + sqrt(1-h^2) N(0, 1), where h^2 = heritability

or

g' = sqrt(h) * g + sqrt(1-h) N(0, 1), where h = heritability

@RossDeVito
Copy link
Author

I have a branch that fixes this, but it doesn't seem like I have permission to push

@RossDeVito
Copy link
Author

Here is the fix: 13315fa

@RossDeVito
Copy link
Author

#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant