fix(opensandbox): derive endpoint scheme from SDK config

Signed-off-by: Jeff Peng <jepeng@nvidia.com>

Author: JeffPengCoder

nemo_gym/sandbox/providers/opensandbox/provider.py

@@ -971,12 +971,9 @@ async def endpoint(
         if not endpoint_url:
             raise RuntimeError(f"OpenSandbox returned an empty endpoint for sandbox {handle.sandbox_id!r} port {port}")
         if "://" not in endpoint_url:
-            domain = str(self._connection.domain or "")
-            # urlsplit("host.example:8080") treats the hostname as a scheme.
-            # Only read a scheme from a domain that actually contains ``://``;
-            # otherwise use ConnectionConfig.protocol just as the SDK does.
-            domain_scheme = urlsplit(domain).scheme if "://" in domain else ""
-            scheme = domain_scheme or self._connection.protocol or "http"
+            # Use the SDK handle's effective configuration so environment-
+            # resolved domains and protocols match the lifecycle request.
+            scheme = urlsplit(handle.raw.connection_config.get_base_url()).scheme or "http"
             endpoint_url = f"{scheme}://{endpoint_url.lstrip('/')}"
         headers = dict(handle.raw.connection_config.headers)
         # Match the SDK's service adapters: connection-wide headers apply to

tests/unit_tests/test_opensandbox_provider.py

@@ -286,6 +286,7 @@ async def test_pool_create_uses_sdk_compatibility_image_and_proxy_auth(
 async def test_endpoint_normalizes_missing_scheme_and_merges_sdk_headers() -> None:
     class FakeRaw:
         connection_config = SimpleNamespace(
+            get_base_url=lambda: "https://sandbox.example/v1",
             headers={
                 "OPEN-SANDBOX-API-KEY": "pool-api-key",  # pragma: allowlist secret
                 "X-Shared": "connection",
@@ -325,18 +326,17 @@ async def get_endpoint(self, port: int) -> Any:
     }
 
 
-async def test_endpoint_uses_configured_protocol_for_domain_without_scheme() -> None:
+async def test_endpoint_uses_effective_sdk_scheme_when_provider_input_is_unset() -> None:
     class FakeRaw:
-        connection_config = SimpleNamespace(headers={})
+        connection_config = SimpleNamespace(
+            get_base_url=lambda: "https://gateway.example/v1",
+            headers={},
+        )
 
         async def get_endpoint(self, _port: int) -> Any:
             return SimpleNamespace(endpoint="sandbox.example:5000", headers={})
 
     provider = opensandbox_provider.OpenSandboxProvider(
-        connection={
-            "domain": "gateway.example:8080/",
-            "protocol": "https",
-        },
         operations={"retries": 0},
         probe={"command": None},
     )