test(files): use FilesClient list_files and download_file in S3 default-storage tests

client_with_s3_default is now a NemoClient, whose .files is a FilesClient
without the old SDK's list and download_content helpers. These tests are
skipped unless RUN_EXTERNAL_STORAGE_TESTS is set, so CI did not catch it.

Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>

Author: maxdubrinsky

services/core/files/tests/integration/external_storage/test_s3_storage.py

@@ -607,19 +607,12 @@ def test_upload_download_with_s3_default(self, client_with_s3_default: NemoClien
             )
 
             # List files
-            files_response = client_with_s3_default.files.list(
-                fileset=fileset.name,
-                workspace=fileset.workspace,
-            )
+            files_response = files.list_files(name=fileset.name, workspace=fileset.workspace).data().data
             assert len(files_response) == 1
             assert files_response[0].path == "test.txt"
 
             # Download and verify content
-            downloaded = client_with_s3_default.files.download_content(
-                remote_path="test.txt",
-                fileset=fileset.name,
-                workspace=fileset.workspace,
-            )
+            downloaded = files.download_file(name=fileset.name, workspace=fileset.workspace, path="test.txt").read()
             assert downloaded == test_content
         finally:
             files.delete_fileset(name=name, workspace=DEFAULT_WORKSPACE)
@@ -662,16 +655,12 @@ def test_multiple_filesets_isolated_with_s3_default(self, client_with_s3_default
             )
 
             # Verify isolation
-            content1 = client_with_s3_default.files.download_content(
-                remote_path="shared-name.txt",
-                fileset=fileset1.name,
-                workspace=fileset1.workspace,
-            )
-            content2 = client_with_s3_default.files.download_content(
-                remote_path="shared-name.txt",
-                fileset=fileset2.name,
-                workspace=fileset2.workspace,
-            )
+            content1 = files.download_file(
+                name=fileset1.name, workspace=fileset1.workspace, path="shared-name.txt"
+            ).read()
+            content2 = files.download_file(
+                name=fileset2.name, workspace=fileset2.workspace, path="shared-name.txt"
+            ).read()
 
             assert content1 == b"content for fileset 1"
             assert content2 == b"content for fileset 2"
@@ -706,10 +695,7 @@ def test_download_from_huggingface_fileset_with_s3_default(self, client_with_s3_
 
         try:
             # List files to verify connection works
-            files = client_with_s3_default.files.list(
-                fileset=fileset.name,
-                workspace=fileset.workspace,
-            )
+            files = files_client.list_files(name=fileset.name, workspace=fileset.workspace).data().data
             assert len(files) > 0, "Expected files in the HuggingFace repo"
 
             # Find config.json (typically small and always present in model repos)
@@ -719,11 +705,9 @@ def test_download_from_huggingface_fileset_with_s3_default(self, client_with_s3_
             )
 
             # Download the file - this exercises preflight validation
-            content = client_with_s3_default.files.download_content(
-                remote_path=config_file.path,
-                fileset=fileset.name,
-                workspace=fileset.workspace,
-            )
+            content = files_client.download_file(
+                name=fileset.name, workspace=fileset.workspace, path=config_file.path
+            ).read()
 
             assert len(content) > 0, "Downloaded content should not be empty"