Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Please remove CMake warning 'pybind11 support disabled. Visualizations and file IO will be disabled' #800

Closed
dagardner-nv opened this issue Nov 12, 2024 · 1 comment · Fixed by #801

Comments

@dagardner-nv
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This warning isn't particularly helpful when all three options are disabled. Considering that MATX_EN_FILEIO, MATX_EN_PYBIND11 and MATX_EN_VISUALIZATION all default to OFF this warning is emitted when building with the project defaults.

Describe the solution you'd like
Ideally this warning shouldn't be displayed.

In the event that either MATX_EN_FILEIO or MATX_EN_VISUALIZATION is enabled but MATX_EN_PYBIND11 is disabled, this should be considered a fatal error and not a warning.

Describe alternatives you've considered
Continue ignoring this CMake warning.

@dagardner-nv
Copy link
Contributor Author

@cliffburdick thanks for the quick turn-around on this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant