Fix Qwen3 recipe and update autoquant example cmd #749
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: weimingc <[email protected]>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
=======================================
Coverage 74.65% 74.66%
=======================================
Files 192 192
Lines 18969 18975 +6
=======================================
+ Hits 14162 14167 +5
- Misses 4807 4808 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
realAsma
reviewed
Jan 14, 2026
Comment on lines
+183
to
+188
| if model_type in ["qwen3moe", "qwen3next"] and qformat == "nvfp4": | ||
| # Disable the attention projection layers to retain accuracy | ||
| quant_cfg["quant_cfg"]["model*.*attn*in_proj*"] = {"enable": False} | ||
| quant_cfg["quant_cfg"]["model*.*attn*q_proj*"] = {"enable": False} | ||
| quant_cfg["quant_cfg"]["model*.*attn*k_proj*"] = {"enable": False} | ||
| quant_cfg["quant_cfg"]["model*.*attn*v_proj*"] = {"enable": False} |
Contributor
There was a problem hiding this comment.
Is there an option to skip this setting? We are hardcoding skipping of attention here.
Cc @shengliangxu - config system and model based config examples could be helpful to improve the overall experience.
Collaborator
There was a problem hiding this comment.
Sure. Right now feel free to add an additional flag for auto quant.
Contributor
Author
There was a problem hiding this comment.
We can refactor this part once the config system is ready.
cjluo-nv
approved these changes
Jan 14, 2026
kevalmorabia97
pushed a commit
that referenced
this pull request
Jan 15, 2026
## What does this PR do? **Type of change:** Bug fix <!-- Use one of the following: Bug fix, new feature, new example, new tests, documentation. --> **Overview:** ? ## Usage <!-- You can potentially add a usage example below. --> ```python # Add a code snippet demonstrating how to use this ``` ## Testing <!-- Mention how have you tested your change if applicable. --> ## Before your PR is "*Ready for review*" <!-- If you haven't finished some of the above items you can still open `Draft` PR. --> - **Make sure you read and follow [Contributor guidelines](https://github.com/NVIDIA/Model-Optimizer/blob/main/CONTRIBUTING.md)** and your commits are signed. - **Is this change backward compatible?**: Yes/No <!--- If No, explain why. --> - **Did you write any new necessary tests?**: Yes/No - **Did you add or update any necessary documentation?**: Yes/No - **Did you update [Changelog](https://github.com/NVIDIA/Model-Optimizer/blob/main/CHANGELOG.rst)?**: Yes/No <!--- Only for new features, API changes, critical bug fixes or bw breaking changes. --> ## Additional Information <!-- E.g. related issue. --> Signed-off-by: weimingc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Bug fix
Overview: ?
Usage
# Add a code snippet demonstrating how to use thisTesting
Before your PR is "Ready for review"
Additional Information