Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BERT Model To NeMo2.0 #11333

Merged
merged 59 commits into from
Dec 5, 2024
Merged

Add BERT Model To NeMo2.0 #11333

merged 59 commits into from
Dec 5, 2024

Conversation

suiyoubi
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@suiyoubi suiyoubi requested a review from JRD971000 November 20, 2024 01:34
@suiyoubi suiyoubi added Run CICD and removed Run CICD labels Dec 2, 2024

HAVE_TE = True
try:
import transformer_engine # pylint: disable=W0611

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'transformer_engine' is not used.
@suiyoubi suiyoubi added Run CICD and removed Run CICD labels Dec 2, 2024
@suiyoubi suiyoubi added Run CICD and removed Run CICD labels Dec 2, 2024
@suiyoubi suiyoubi added Run CICD and removed Run CICD labels Dec 3, 2024
@suiyoubi suiyoubi added Run CICD and removed Run CICD labels Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

beep boop 🤖: 🚨 The following files must be fixed before merge!


Your code was analyzed with PyLint. The following annotations have been identified:


------------------------------------
Your code has been rated at 10.00/10

Thank you for improving NeMo's documentation!

Copy link
Contributor

github-actions bot commented Dec 3, 2024

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:


------------------------------------
Your code has been rated at 10.00/10

Thank you for improving NeMo's documentation!

Copy link
Contributor

github-actions bot commented Dec 3, 2024

beep boop 🤖: 🚨 The following files must be fixed before merge!


Your code was analyzed with PyLint. The following annotations have been identified:


------------------------------------
Your code has been rated at 10.00/10

Thank you for improving NeMo's documentation!

Copy link
Contributor

github-actions bot commented Dec 4, 2024

[🤖]: Hi @suiyoubi 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

Copy link
Collaborator

@JRD971000 JRD971000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot @suiyoubi

@JRD971000 JRD971000 enabled auto-merge (squash) December 5, 2024 21:45
@JRD971000 JRD971000 merged commit 8014001 into main Dec 5, 2024
172 of 173 checks passed
@JRD971000 JRD971000 deleted the aot/bert-nemo-ux branch December 5, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants