Bug
The TS migration in #1271 simplified the nimStatusByName test assertions, dropping the command-verification checks that validate port resolution branching:
- "falls back to 8000" no longer verifies
localhost:8000 was actually used
- "uses published docker port" no longer verifies
localhost:9000 was used
- "does not run health check when container is not running" no longer verifies docker port and health check commands were skipped
Without these, the tests just check healthy: true/false without confirming the port resolution logic picked the right port.
Fix
Restore the commands.some(cmd => cmd.includes(...)) assertions that were present in the original JS tests.
Found by
Review of #1271.
Bug
The TS migration in #1271 simplified the
nimStatusByNametest assertions, dropping the command-verification checks that validate port resolution branching:localhost:8000was actually usedlocalhost:9000was usedWithout these, the tests just check
healthy: true/falsewithout confirming the port resolution logic picked the right port.Fix
Restore the
commands.some(cmd => cmd.includes(...))assertions that were present in the original JS tests.Found by
Review of #1271.