Skip to content

Conversation

@greg-kwasniewski1
Copy link
Collaborator

@greg-kwasniewski1 greg-kwasniewski1 commented Dec 2, 2025

Restoring autodeploy tests related to bug https://nvbugs/5680312 , fixed after PR #9145

Summary by CodeRabbit

  • Tests
    • Removed six test waivers to enable validation of previously exempted tests.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@greg-kwasniewski1
Copy link
Collaborator Author

/bot run --add-multi-gpu-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 2, 2025

📝 Walkthrough

Walkthrough

Removed six test waiver entries from the integration test waiver list. The removed entries represent previously skipped tests across multiple test modules. No functional logic changes; only data modifications to the waiver configuration file.

Changes

Cohort / File(s) Summary
Test waiver list updates
tests/integration/test_lists/waives.txt
Removed six SKIP entries for: accuracy/test_llm_api_autodeploy.py (2 test cases), unittest/_torch/auto_deploy/unit/multigpu/test_ad_build_small_multi.py (1 test case), examples/test_ray.py (1 test case), full:H100_PCIe/unittest/llmapi/test_llm_pytorch.py (1 test case), and unittest/_torch/speculative/test_draft_len_schedule.py (1 test case)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify that the removed test identifiers match intended test paths and are correctly spelled
  • Confirm these tests are now expected to pass (or no longer require waiver)
  • Ensure no unintended waiver entries were accidentally removed

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning PR description is incomplete. Only the issue reference is provided; required sections (Description, Test Coverage) are empty templates without substantive content. Fill in the Description section explaining what bug was fixed and why tests are being restored. Add Test Coverage section listing the specific tests being re-enabled.
Title check ❓ Inconclusive The title '[https://nvbugs/5680312][fix] Updated test waiving' is vague and generic, using non-descriptive terms like 'Updated' that don't clearly convey what specific tests or issues are being addressed in the changeset. Consider a more specific title such as '[https://nvbugs/5680312][fix] Remove waived tests after LLM autodeploy and speculative decoding fixes' to clearly indicate which test waivers were removed and why.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greg-kwasniewski1 greg-kwasniewski1 changed the title [https://nvbugs/5680312][fix] Removed sharding tests from waives after the bug fix [https://nvbugs/1234567][fix] Fix some bugs Dec 2, 2025
@greg-kwasniewski1 greg-kwasniewski1 changed the title [https://nvbugs/1234567][fix] Fix some bugs [https://nvbugs/5680312][fix] Fix some bugs Dec 2, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #26647 [ run ] triggered by Bot. Commit: efbc47a

@greg-kwasniewski1 greg-kwasniewski1 changed the title [https://nvbugs/5680312][fix] Fix some bugs [https://nvbugs/5680312][fix] Updated test waiving Dec 2, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #26647 [ run ] completed with state SUCCESS. Commit: efbc47a
/LLM/main/L0_MergeRequest_PR pipeline #20273 completed with status: 'FAILURE'

@greg-kwasniewski1
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26748 [ run ] triggered by Bot. Commit: efbc47a

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26748 [ run ] completed with state SUCCESS. Commit: efbc47a
/LLM/main/L0_MergeRequest_PR pipeline #20362 completed with status: 'SUCCESS'

Copy link
Member

@lucaslie lucaslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greg-kwasniewski1, doesn't look like the pipeline triggered multi-gpu tests and the one with multi-gpu actually failed on an autodeploy test

@greg-kwasniewski1
Copy link
Collaborator Author

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26786 [ run ] triggered by Bot. Commit: 87eb382

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26786 [ run ] completed with state FAILURE. Commit: 87eb382

@greg-kwasniewski1
Copy link
Collaborator Author

/bot run --add-multi-gpu-test

@greg-kwasniewski1 greg-kwasniewski1 enabled auto-merge (squash) December 3, 2025 15:50
@tensorrt-cicd
Copy link
Collaborator

PR_Github #26809 [ run ] triggered by Bot. Commit: c9a5091

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26809 [ run ] completed with state SUCCESS. Commit: c9a5091
/LLM/main/L0_MergeRequest_PR pipeline #20417 completed with status: 'FAILURE'

@greg-kwasniewski1
Copy link
Collaborator Author

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26831 [ run ] triggered by Bot. Commit: 8728e11

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26831 [ run ] completed with state SUCCESS. Commit: 8728e11
/LLM/main/L0_MergeRequest_PR pipeline #20436 completed with status: 'FAILURE'

@greg-kwasniewski1
Copy link
Collaborator Author

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26922 [ run ] triggered by Bot. Commit: a705ce6

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26922 [ run ] completed with state FAILURE. Commit: a705ce6
/LLM/main/L0_MergeRequest_PR pipeline #20515 completed with status: 'FAILURE'

@greg-kwasniewski1
Copy link
Collaborator Author

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26944 [ run ] triggered by Bot. Commit: a705ce6

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26944 [ run ] completed with state SUCCESS. Commit: a705ce6
/LLM/main/L0_MergeRequest_PR pipeline #20532 completed with status: 'FAILURE'

@greg-kwasniewski1
Copy link
Collaborator Author

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26971 [ run ] triggered by Bot. Commit: 14af788

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26971 [ run ] completed with state SUCCESS. Commit: 14af788
/LLM/main/L0_MergeRequest_PR pipeline #20559 completed with status: 'FAILURE'

@greg-kwasniewski1
Copy link
Collaborator Author

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26993 [ run ] triggered by Bot. Commit: db85d51

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26993 [ run ] completed with state SUCCESS. Commit: db85d51
/LLM/main/L0_MergeRequest_PR pipeline #20580 completed with status: 'FAILURE'

@greg-kwasniewski1
Copy link
Collaborator Author

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27022 [ run ] triggered by Bot. Commit: 7aff03a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants