From f0ee1c905a91267ed0908e2363f40608f01107ce Mon Sep 17 00:00:00 2001 From: Bernhard Manfred Gruber Date: Thu, 4 Jul 2024 13:31:01 +0200 Subject: [PATCH] Reviewer feedback --- libcudacxx/include/cuda/std/detail/libcxx/include/cmath | 2 +- thrust/thrust/system/cuda/detail/core/triple_chevron_launch.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libcudacxx/include/cuda/std/detail/libcxx/include/cmath b/libcudacxx/include/cuda/std/detail/libcxx/include/cmath index 40644f70dbd..ba26c8ea1ff 100644 --- a/libcudacxx/include/cuda/std/detail/libcxx/include/cmath +++ b/libcudacxx/include/cuda/std/detail/libcxx/include/cmath @@ -973,7 +973,7 @@ _LIBCUDACXX_INLINE_VISIBILITY constexpr _Fp __lerp(_Fp __a, _Fp __b, _Fp __t) no return __b; } const _Fp __x = __a + __t * (__b - __a); - if ((__t > 1) == (__b > __a)) + if (__t > 1 == __b > __a) { return __b < __x ? __x : __b; } diff --git a/thrust/thrust/system/cuda/detail/core/triple_chevron_launch.h b/thrust/thrust/system/cuda/detail/core/triple_chevron_launch.h index 51d81b4f299..af68892dcdf 100644 --- a/thrust/thrust/system/cuda/detail/core/triple_chevron_launch.h +++ b/thrust/thrust/system/cuda/detail/core/triple_chevron_launch.h @@ -90,7 +90,7 @@ struct _CCCL_VISIBILITY_HIDDEN triple_chevron } template - void _CCCL_DEVICE copy_arg(char*& buffer, size_t& offset, Arg arg) const + void _CCCL_DEVICE copy_arg(char* buffer, size_t& offset, Arg arg) const { // TODO(bgruber): we should make sure that we can actually byte-wise copy Arg, but this fails with some tests // static_assert(::cuda::std::is_trivially_copyable::value, "");