Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to feature flag to guard for deduction guides #1704

Open
miscco opened this issue May 6, 2024 · 0 comments
Open

Move to feature flag to guard for deduction guides #1704

miscco opened this issue May 6, 2024 · 0 comments
Assignees

Comments

@miscco
Copy link
Collaborator

miscco commented May 6, 2024

We are currently guarding the deduction guides by standard year but we should just use the feature flag

          Question: doesn't this fail for compilers with partial C++17 support and `-std=c++1z`?

Suggestion: test for the feature instead:

#ifdef __cpp_deduction_guides
template <class _T1, class _T2>
_CCCL_HOST_DEVICE pair(_T1, _T2) -> pair<_T1, _T2>;
#endif // __cpp_deduction_guides

Originally posted by @bernhardmgruber in #1643 (comment)

@bernhardmgruber bernhardmgruber self-assigned this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants