Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUB's NVTX ranges fail to compile when usercode uses explicitly versioned NVTX API #1750

Closed
bernhardmgruber opened this issue May 16, 2024 · 0 comments · Fixed by #1751
Closed
Assignees
Labels
bug Something isn't working right. cub For all items related to CUB

Comments

@bernhardmgruber
Copy link
Contributor

CUB provides NVTX ranges internally for the device scope algorithms. It uses the NVTX v3 C++ wrapper to achieve this, which comes in two API flavors: an explicitly versioned one and the implicit API. Depending on whether NVTX3_CPP_REQUIRE_EXPLICIT_VERSION is defined or not, one API flavor is provided by the NVTX headers. Since CUB programs against the implicit API, it fails to compile when the user requested the explicit API.

The following program fails to compile:

#define NVTX3_CPP_REQUIRE_EXPLICIT_VERSION
#include <nvtx3/nvtx3.hpp>
#include <cub/device/device_reduce.cuh>

int main() {}

Originally posted by @gevtushenko in #1688 (comment)

@bernhardmgruber bernhardmgruber changed the title CUB's NVTX ranges fail to compile when user code uses explicitly versioned NVTX API CUB's NVTX ranges fail to compile when usercode uses explicitly versioned NVTX API May 16, 2024
@bernhardmgruber bernhardmgruber added cub For all items related to CUB bug Something isn't working right. labels May 16, 2024
@bernhardmgruber bernhardmgruber self-assigned this May 16, 2024
bernhardmgruber added a commit to bernhardmgruber/cccl that referenced this issue May 16, 2024
The explicit API is always available.

Fixes: NVIDIA#1750
bernhardmgruber added a commit to bernhardmgruber/cccl that referenced this issue May 20, 2024
The explicit V1 API is always available. See discussion here:
NVIDIA/NVTX#96

Fixes: NVIDIA#1750
bernhardmgruber added a commit to bernhardmgruber/cccl that referenced this issue May 20, 2024
The explicit V1 API is always available. See discussion here:
NVIDIA/NVTX#96

Fixes: NVIDIA#1750
bernhardmgruber added a commit to bernhardmgruber/cccl that referenced this issue Jun 4, 2024
The explicit V1 API is always available. See discussion here:
NVIDIA/NVTX#96

Fixes: NVIDIA#1750
bernhardmgruber added a commit to bernhardmgruber/cccl that referenced this issue Jul 5, 2024
The explicit V1 API is always available. See discussion here:
NVIDIA/NVTX#96

Fixes: NVIDIA#1750
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right. cub For all items related to CUB
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant