Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI testing for memory errors #1775

Closed
bernhardmgruber opened this issue May 24, 2024 · 2 comments
Closed

CI testing for memory errors #1775

bernhardmgruber opened this issue May 24, 2024 · 2 comments

Comments

@bernhardmgruber
Copy link
Contributor

bernhardmgruber commented May 24, 2024

The CUB device histogram tests had explicit checking for out-of-bounds accesses by allocating canary zones before and after temporary storage, filled with a known byte pattern before the CUB algorithm invocation and verified afterwards. These checks were removed as part of the port to Catch2 in #1695.

We could generally investigate ideas about checking for memory errors in the CI, e.g. using dedicated tools like ASAN or compute-sanitizer, or generalize the canary zone approach to larger parts of the testing infrastructure (adding it to the CUB launch wrappers).

Originally posted by @gevtushenko in #1695 (comment)

@alliepiper
Copy link
Collaborator

alliepiper commented Jun 24, 2024

Closing as a duplicate of #1618, which will be addressed in #1879. compute-santizer's --padding arg does exactly what we want here.

@bernhardmgruber
Copy link
Contributor Author

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants