Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Do not use inline variables prior to C++17 #191

Open
1 task done
miscco opened this issue Jul 10, 2023 · 0 comments
Open
1 task done

[BUG]: Do not use inline variables prior to C++17 #191

miscco opened this issue Jul 10, 2023 · 0 comments
Assignees
@miscco
Labels
bug Something isn't working right. libcu++ For all items related to libcu++

Comments

@miscco
Copy link
Collaborator

miscco commented Jul 10, 2023

Is this a duplicate?

Type of Bug

Silent Failure

Component

libcu++

Describe the bug

Inline variables are a C++17 feature. We should not use them, as a compiler could potentially create duplicated symbols for each ocurrence.

How to Reproduce

Search for _v< in product code and check whether this is available prior to C++17

Expected behavior

We should not use inline variables directly, but rather use traits via our _LIBCUDACXX_TRAIT macro

Reproduction link

No response

Operating System

No response

nvidia-smi output

No response

NVCC version

No response
@miscco miscco changed the title [BUG]: Do not use inline variables prio to C++17 [BUG]: Do not use inline variables prior to C++17 Jul 10, 2023
@miscco miscco self-assigned this Jul 10, 2023
@miscco miscco added libcu++ For all items related to libcu++ bug Something isn't working right. labels Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miscco miscco

Labels
bug Something isn't working right. libcu++ For all items related to libcu++
Projects
CCCL
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@miscco