Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Come up with plan for coupling between async_resource and resource concept #2313

Open
Tracked by #1502
jrhemstad opened this issue Aug 28, 2024 · 2 comments
Open
Tracked by #1502
Assignees

Comments

@jrhemstad
Copy link
Collaborator

jrhemstad commented Aug 28, 2024

Today, async_resource concept is a strict superset of resource which requires an async_resource to provide synchronous allocation APIs. This introduces a problem where you have to decide what stream to allocate on.

We should figure out what, if anything, we want to do about that, including decoupling async_resource and resource concepts.

We can close this issue when we have a plan on what we decide to do about this.

@jrhemstad
Copy link
Collaborator Author

jrhemstad commented Sep 4, 2024

@miscco synced with @harrism and RAPIDS is fine with decoupling the concepts since RAPIDS is only really interested in the async resources anyways.

The current plan is to just get #1637 merged by removing the sync from the deallocate and then worry about decoupling (if at all) later.

@harrism
Copy link
Contributor

harrism commented Sep 10, 2024

I think RAPIDS is probably interested in synchronous resources in certain situations, but I don't see a requirement to be able to use a single resource instance as both synchronous and asynchronous at the same time. So it seems fine to decouple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants