Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Factor out devcontainer version to the matrix.yaml #241

Closed
1 task done
Tracked by #245
jrhemstad opened this issue Jul 18, 2023 · 1 comment
Closed
1 task done
Tracked by #245

[FEA]: Factor out devcontainer version to the matrix.yaml #241

jrhemstad opened this issue Jul 18, 2023 · 1 comment

Comments

@jrhemstad
Copy link
Collaborator

Is this a duplicate?

Area

Infrastructure

Is your feature request related to a problem? Please describe.

As a maintainer of CCCL's actions workflows and devcontainers, I want to be able to easily update the version of the base images we're using from https://github.com/rapidsai/devcontainers.

Today, that version is hardcoded to 23.06 in a few different places:

This makes it difficult to consistently update this version.

Describe the solution you'd like

There should be a single source of truth for the devcontainer image version. I think this should be defined in the matrix.yaml as a new top-level field like:

devcontainer_version: '23.06'

Then all other uses should derive from this single source of truth.

Describe alternatives you've considered

No response

Additional context

No response

@jrhemstad
Copy link
Collaborator Author

Closed by #270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant