Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Add a job to CI to verify that devcontainers are up to date #242

Closed
1 task done
jrhemstad opened this issue Jul 18, 2023 · 0 comments · Fixed by #514
Closed
1 task done

[FEA]: Add a job to CI to verify that devcontainers are up to date #242

jrhemstad opened this issue Jul 18, 2023 · 0 comments · Fixed by #514
Assignees

Comments

@jrhemstad
Copy link
Collaborator

Is this a duplicate?

Area

Infrastructure

Is your feature request related to a problem? Please describe.

As a CCCL developer, I rely on the Dev Containers defined .devcontainer/ for my local development envinroment.

These devcontainer.json files are generated using the .devcontainer/make_devcontainers.sh script that parses the ci/matrix.yaml file and collects the unique versions of CUDA/host compiler and then creates a .devcontainer/ subdirectory for each.

The .devcontainer/devcontainer.json file is treated as the template, and all the other devcontainer.json files are just copies that replace the image: field.

It would be easy for these devcontainer.json files to get out of date if we ever made changes and forgot to run the make_devcontainers.sh script.

Describe the solution you'd like

We should add a job to CI that runs the make_devcontainer.sh script and will fail if there are any changes to any of the files (meaning they are out of date and need to be updated).

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant