Brings the Java build in line with other clients. (#2361)

Fixes several build issues that previously allowed improperly formatted files and files with incorrect copyright headers to pass CI.
- Replaces the Java-specific copyright check with the standard pre-commit check.
- Adds Java and Maven dependencies to the all configuration.
- Moves formatting and Spotless checks into pre-commit.
- Fixes formatting in files that were not properly formatted.
- Removes the remaining headers_h_1 imports.

Fixes #2131

Authors:
  - Igor Motov (https://github.com/imotov)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - James Lamb (https://github.com/jameslamb)

URL: #2361

Author: imotov

.pre-commit-config.yaml

@@ -93,6 +93,13 @@ repos:
         pass_filenames: false
         files: rust/.*
         language: rust
+      - id: spotless-fmt
+        name: spotless-fmt
+        entry: ci/checks/run_spotless.sh
+        pass_filenames: false
+        files: ^java/cuvs-java/src/.*\.java$
+        exclude: .*/panama/.*
+        language: script
       - id: clang-format-with-cmake-placeholders
         name: clang-format-with-cmake-placeholders
         entry: python3 ci/checks/clang_format_with_cmake_placeholders.py

ci/checks/run_spotless.sh

@@ -0,0 +1,23 @@
+#!/bin/bash
+# SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# SPDX-License-Identifier: Apache-2.0
+
+# pre-commit hook wrapper that runs 'spotless:apply' to format the Java client sources.
+#
+# Most cuvs contributors do not work on the Java client and do not have Maven installed. For them
+# (running outside CI without Maven) this skips gracefully, so that 'pre-commit run --all-files'
+# does not require every contributor to install Maven. In CI, Maven is expected to be available and
+# its absence is treated as an error.
+
+set -euo pipefail
+
+if ! command -v mvn >/dev/null 2>&1; then
+  if [ "${CI:-false}" = "true" ]; then
+    echo "spotless-fmt: 'mvn' is required in CI but was not found on PATH." >&2
+    exit 1
+  fi
+  echo "spotless-fmt: skipping Java formatting ('mvn' not installed and not running in CI)." >&2
+  exit 0
+fi
+
+exec mvn --batch-mode --quiet -f java/cuvs-java/pom.xml spotless:apply

conda/environments/all_cuda-129_arch-aarch64.yaml

@@ -30,11 +30,13 @@ dependencies:
 - libopenblas<=0.3.30
 - librmm==26.10.*,>=0.0.0a0
 - make
+- maven
 - nccl>=2.19
 - ninja
 - nodejs>=22
 - numpy>=2.0,<3.0
 - openblas
+- openjdk=22.*
 - pre-commit
 - pylibraft==26.10.*,>=0.0.0a0
 - pytest

conda/environments/all_cuda-129_arch-x86_64.yaml

@@ -29,11 +29,13 @@ dependencies:
 - libnvjitlink-dev
 - librmm==26.10.*,>=0.0.0a0
 - make
+- maven
 - nccl>=2.19
 - ninja
 - nodejs>=22
 - numpy>=2.0,<3.0
 - openblas
+- openjdk=22.*
 - pre-commit
 - pylibraft==26.10.*,>=0.0.0a0
 - pytest

conda/environments/all_cuda-133_arch-aarch64.yaml

@@ -30,11 +30,13 @@ dependencies:
 - libopenblas<=0.3.30
 - librmm==26.10.*,>=0.0.0a0
 - make
+- maven
 - nccl>=2.19
 - ninja
 - nodejs>=22
 - numpy>=2.0,<3.0
 - openblas
+- openjdk=22.*
 - pre-commit
 - pylibraft==26.10.*,>=0.0.0a0
 - pytest

conda/environments/all_cuda-133_arch-x86_64.yaml

@@ -29,11 +29,13 @@ dependencies:
 - libnvjitlink-dev
 - librmm==26.10.*,>=0.0.0a0
 - make
+- maven
 - nccl>=2.19
 - ninja
 - nodejs>=22
 - numpy>=2.0,<3.0
 - openblas
+- openjdk=22.*
 - pre-commit
 - pylibraft==26.10.*,>=0.0.0a0
 - pytest

dependencies.yaml

@@ -297,6 +297,11 @@ dependencies:
       - output_types: [conda]
         packages:
           - c-compiler
+      # spotless-fmt pre-commit hook requires Maven and a JDK
+      - output_types: [conda]
+        packages:
+          - maven
+          - &openjdk openjdk=22.*
   clang:
     common:
       - output_types: conda
@@ -591,7 +596,7 @@ dependencies:
           - *cmake_ver
           - libboost-devel
           - maven
-          - openjdk=22.*
+          - *openjdk
   bench:
     common:
       - output_types: [conda, pyproject, requirements]

java/cuvs-java/pom.xml

@@ -252,14 +252,6 @@ SPDX-License-Identifier: Apache-2.0
                 <groupId>com.diffplug.spotless</groupId>
                 <artifactId>spotless-maven-plugin</artifactId>
                 <version>2.44.5</version>
-                <executions>
-                    <execution>
-                        <goals>
-                            <goal>apply</goal>
-                        </goals>
-                        <phase>validate</phase>
-                    </execution>
-                </executions>
                 <configuration>
                     <java>
                         <includes>
@@ -268,15 +260,21 @@ SPDX-License-Identifier: Apache-2.0
                         <excludes>
                             <exclude>src/**/panama/*.java</exclude>
                         </excludes>
+                        <!--
+                            TODO: When we have more rules that should go to checkstyle or PMD
+                            (tracking issue: https://github.com/NVIDIA/cuvs/issues/2364)
+                        -->
+                        <replaceRegex>
+                            <name>Use the headers_h facade, not numbered jextract classes</name>
+                            <searchRegex>\bheaders_h_[0-9]+\b</searchRegex>
+                            <replacement>headers_h</replacement>
+                        </replaceRegex>
                         <googleJavaFormat>
                             <version>1.27.0</version>
                             <style>GOOGLE</style>
                             <reflowLongStrings>true</reflowLongStrings>
                             <formatJavadoc>false</formatJavadoc>
                         </googleJavaFormat>
-                        <licenseHeader>
-                            <file>${project.basedir}/../license-header.txt</file>
-                        </licenseHeader>
                     </java>
                 </configuration>
             </plugin>

java/cuvs-java/src/main/java/com/nvidia/cuvs/CuVSAceParams.java

@@ -1,5 +1,5 @@
 /*
- * SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION.
+ * SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
  * SPDX-License-Identifier: Apache-2.0
  */
 package com.nvidia.cuvs;
@@ -75,8 +75,13 @@ public class CuVSAceParams {
    */
   private final double maxGpuMemoryGb;
 
-  private CuVSAceParams(long npartitions, long efConstruction, String buildDir, boolean useDisk,
-                        double maxHostMemoryGb, double maxGpuMemoryGb) {
+  private CuVSAceParams(
+      long npartitions,
+      long efConstruction,
+      String buildDir,
+      boolean useDisk,
+      double maxHostMemoryGb,
+      double maxGpuMemoryGb) {
     this.npartitions = npartitions;
     this.efConstruction = efConstruction;
     this.buildDir = buildDir;
@@ -259,8 +264,8 @@ public Builder withMaxGpuMemoryGb(double maxGpuMemoryGb) {
      * @return an instance of {@link CuVSAceParams}
      */
     public CuVSAceParams build() {
-      return new CuVSAceParams(npartitions, efConstruction, buildDir, useDisk,
-                               maxHostMemoryGb, maxGpuMemoryGb);
+      return new CuVSAceParams(
+          npartitions, efConstruction, buildDir, useDisk, maxHostMemoryGb, maxGpuMemoryGb);
     }
   }
 }

java/cuvs-java/src/main/java/com/nvidia/cuvs/CuVSResources.java

@@ -122,11 +122,9 @@ static CuVSResources create(Path tempDirectory) throws Throwable {
    * @throws LibraryException if the native library cannot be loaded
    */
   static CuVSResources create(
-      Path tempDirectory,
-      Path memoryTrackingCsvPath,
-      Duration memoryTrackingSampleInterval) throws Throwable {
+      Path tempDirectory, Path memoryTrackingCsvPath, Duration memoryTrackingSampleInterval)
+      throws Throwable {
     return CuVSProvider.provider()
-        .newCuVSResources(
-            tempDirectory, memoryTrackingCsvPath, memoryTrackingSampleInterval);
+        .newCuVSResources(tempDirectory, memoryTrackingCsvPath, memoryTrackingSampleInterval);
   }
 }