Skip to content

Commit fbe71f8

Browse files
committed
simplify GitHub Actions diff, no TTY for docker run
1 parent 6e6d6b6 commit fbe71f8

8 files changed

Lines changed: 14 additions & 11 deletions

File tree

‎.github/workflows/build.yaml‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,12 @@ jobs:
5555
node_type: cpu16
5656
script: ci/build_cpp.sh
5757
sha: ${{ inputs.sha }}
58-
5958
rocky8-clib-standalone-build-matrix:
6059
permissions:
6160
contents: read
6261
uses: rapidsai/shared-workflows/.github/workflows/compute-matrix.yaml@release/26.10
6362
with:
64-
build_type: pull-request
63+
build_type: ${{ inputs.branch }}
6564
matrix_name: conda-cpp-build
6665
rocky8-clib-standalone-build:
6766
needs: [rocky8-clib-standalone-build-matrix]

‎.github/workflows/check-c-abi.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
runs-on: ubuntu-latest
1010
steps:
1111
- name: Checkout PR branch
12-
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
12+
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
1313
with:
1414
fetch-depth: 0
1515
persist-credentials: false

‎.github/workflows/pr.yaml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -555,7 +555,6 @@ jobs:
555555
build_type: pull-request
556556
script: ci/test_python.sh
557557
rocky8-clib-standalone-build-matrix:
558-
needs: checks
559558
permissions:
560559
contents: read
561560
uses: rapidsai/shared-workflows/.github/workflows/compute-matrix.yaml@release/26.10

‎.github/workflows/publish-rust.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
container:
2222
image: "rapidsai/ci-conda:26.10-cuda${{ matrix.cuda_version }}-ubuntu24.04-py3.13"
2323
steps:
24-
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
24+
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
2525
with:
2626
persist-credentials: false
2727
- name: Check if release build

‎.github/workflows/store-c-abi-baseline.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
contents: write
1919
steps:
2020
- name: Checkout repository
21-
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
21+
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
2222
with:
2323
persist-credentials: false
2424

@@ -31,7 +31,7 @@ jobs:
3131
path: baseline/
3232

3333
- name: Archive baseline with release version
34-
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
34+
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
3535
with:
3636
name: c-abi-baseline-${{ github.event.release.tag_name || inputs.version }}
3737
path: baseline/c_abi.json.gz

‎.github/workflows/update-c-abi-baseline.yaml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
contents: read
1818
steps:
1919
- name: Checkout main branch
20-
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
20+
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
2121
with:
2222
persist-credentials: false
2323

@@ -48,14 +48,14 @@ jobs:
4848
COMMIT: ${{ github.sha }}
4949

5050
- name: Store commit-specific baseline
51-
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
51+
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
5252
with:
5353
name: c-abi-baseline-${{ github.sha }}
5454
path: baseline/c_abi.json.gz
5555
retention-days: 90 # Keep for 3 months
5656

5757
- name: Store main baseline (latest, never expires)
58-
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
58+
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
5959
with:
6060
name: c-abi-baseline-main
6161
path: baseline/c_abi.json.gz

‎build.sh‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -649,8 +649,9 @@ if hasArg tarball; then
649649
-v "${BUILD_OUTPUT_DIR_ABS}:/build:rw" \
650650
"${DOCKER_ENV_VARS[@]}" \
651651
--env CI="${CI:-false}" \
652+
--env RAPIDS_BUILD_TYPE="${RAPIDS_BUILD_TYPE:-}" \
652653
--env-file <(env | grep -E '^AWS_(ACCESS_KEY_ID|SECRET_ACCESS_KEY|SESSION_TOKEN)=') \
653-
-it "${CUVS_TARBALL_IMAGE_NAME}" \
654+
"${CUVS_TARBALL_IMAGE_NAME}" \
654655
"${DOCKER_ENTRYPOINT_ARGS[@]}"
655656

656657
cp -v "${BUILD_OUTPUT_DIR_ABS}/libcuvs_c.tar.gz" "${REPODIR}/libcuvs_c.tar.gz"

‎fern/pages/build.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,10 @@ Use the standalone Docker build when you want a `libcuvs_c.tar.gz` archive that
6060
From the repository root, run:
6161

6262
```bash
63+
# (optional) clean old build directories
64+
rm -rf ./{build,c/build/,cpp/build}
65+
66+
# build
6367
./build.sh tarball
6468
```
6569

0 commit comments

Comments
 (0)