Skip to content

Commit 0cef6c4

Browse files
committed
Merge branch 'master' into 'master'
add filter device-plugin validate container See merge request nvidia/kubernetes/gpu-operator!832
2 parents 53248cf + cc580aa commit 0cef6c4

File tree

1 file changed

+15
-12
lines changed

1 file changed

+15
-12
lines changed

controllers/object_controls.go

+15-12
Original file line numberDiff line numberDiff line change
@@ -1963,16 +1963,6 @@ func TransformValidatorComponent(config *gpuv1.ClusterPolicySpec, podSpec *corev
19631963
if !strings.Contains(initContainer.Name, fmt.Sprintf("%s-validation", component)) {
19641964
continue
19651965
}
1966-
if component == "nvidia-fs" && (config.GPUDirectStorage == nil || !config.GPUDirectStorage.IsEnabled()) {
1967-
// remove nvidia-fs init container from validator Daemonset if GDS is not enabled
1968-
podSpec.InitContainers = append(podSpec.InitContainers[:i], podSpec.InitContainers[i+1:]...)
1969-
return nil
1970-
}
1971-
if component == "cc-manager" && !config.CCManager.IsEnabled() {
1972-
// remove cc-manager init container from validator Daemonset if it is not enabled
1973-
podSpec.InitContainers = append(podSpec.InitContainers[:i], podSpec.InitContainers[i+1:]...)
1974-
return nil
1975-
}
19761966
// update validation image
19771967
image, err := gpuv1.ImagePath(&config.Validator)
19781968
if err != nil {
@@ -2003,6 +1993,11 @@ func TransformValidatorComponent(config *gpuv1.ClusterPolicySpec, podSpec *corev
20031993
setContainerEnv(&(podSpec.InitContainers[i]), ValidatorRuntimeClassEnvName, *podSpec.RuntimeClassName)
20041994
}
20051995
case "plugin":
1996+
// remove plugin init container from validator Daemonset if it is not enabled
1997+
if !config.DevicePlugin.IsEnabled() {
1998+
podSpec.InitContainers = append(podSpec.InitContainers[:i], podSpec.InitContainers[i+1:]...)
1999+
return nil
2000+
}
20062001
// set/append environment variables for plugin-validation container
20072002
if len(config.Validator.Plugin.Env) > 0 {
20082003
for _, env := range config.Validator.Plugin.Env {
@@ -2030,9 +2025,17 @@ func TransformValidatorComponent(config *gpuv1.ClusterPolicySpec, podSpec *corev
20302025
}
20312026
}
20322027
case "nvidia-fs":
2033-
// no additional config required for nvidia-fs validation
2028+
if config.GPUDirectStorage == nil || !config.GPUDirectStorage.IsEnabled() {
2029+
// remove nvidia-fs init container from validator Daemonset if GDS is not enabled
2030+
podSpec.InitContainers = append(podSpec.InitContainers[:i], podSpec.InitContainers[i+1:]...)
2031+
return nil
2032+
}
20342033
case "cc-manager":
2035-
// no additional config required for cc-manager validation
2034+
if !config.CCManager.IsEnabled() {
2035+
// remove cc-manager init container from validator Daemonset if it is not enabled
2036+
podSpec.InitContainers = append(podSpec.InitContainers[:i], podSpec.InitContainers[i+1:]...)
2037+
return nil
2038+
}
20362039
case "toolkit":
20372040
// set/append environment variables for toolkit-validation container
20382041
if len(config.Validator.Toolkit.Env) > 0 {

0 commit comments

Comments
 (0)