Add wildcard tolerations to ComputeDomain pods (issue #305)#306
Merged
jgehrcke merged 1 commit intokubernetes-sigs:mainfrom Mar 26, 2025
Merged
Add wildcard tolerations to ComputeDomain pods (issue #305)#306jgehrcke merged 1 commit intokubernetes-sigs:mainfrom
jgehrcke merged 1 commit intokubernetes-sigs:mainfrom
Conversation
…#305) Signed-off-by: Dr. Jan-Philip Gehrcke <jgehrcke@nvidia.com>
Contributor
Author
|
OK, I tested this on Luna. Confirming that the expected tolerations are set: $ kubectl get pod -n nvidia-dra-driver-gpu imex-channel-injection-c9s9r-5pzxk -o yaml | grep -C15 tolerations
<snip>
nodeSelector:
resource.nvidia.com/computeDomain: 25c467f6-b235-477d-a306-09c8e88311a7
preemptionPolicy: PreemptLowerPriority
priority: 0
resourceClaims:
- name: compute-domain-daemon
resourceClaimTemplateName: imex-channel-injection-daemon-claim-template-w6qnx
<snip>
tolerations:
- effect: NoSchedule
operator: Exists
- effect: NoExecute
operator: Exists
- effect: PreferNoSchedule
operator: Exists
- effect: NoExecute
key: node.kubernetes.io/not-ready
operator: Exists
- effect: NoExecute
key: node.kubernetes.io/unreachable
operator: Exists
- effect: NoSchedule
key: node.kubernetes.io/disk-pressure
operator: ExistsThe top three tolerations are the new catch-alls. The other three are set by k8s by default. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds wildcard tolerations for ComputeDomain pods to address issue #305.
- Adds three wildcard tolerations with effects "NoSchedule", "NoExecute", and "PreferNoSchedule".
- Updates the ComputeDomain daemon template to include these tolerations.
shivamerla
approved these changes
Mar 26, 2025
ArangoGutierrez
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #305. This is not yet tested. Will report back.