Fix ZeroDivisionError #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
How did you encounter this issue? Which metric were you trying to collect? It would be useful if you extend |
Collaborator
|
/ok to test f31deab |
Collaborator
|
@Leymore can you please merge the latest main branch from upstream? We have fixed the CI issues. |
Collaborator
|
/ok to test 11a2042 |
Signed-off-by: Alok Joshi <[email protected]>
Collaborator
|
/ok to test d24ccb0 |
…lue 0 Signed-off-by: Alok Joshi <[email protected]>
Collaborator
|
/ok to test 46f8d11 |
acollins3
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a ZeroDivisionError that occurs when the average value of the measured metric is zero.
The PR also adds a test for collecting the
sm__idc_divergent_instructions.avgmetric which is zero for a simple vector add, hence verifying nsight-python behaviour when metric value is zero.