Skip to content

Commit 94f0263

Browse files
authored
chore(nvca): fix Deprecated doc comment formatting (#230)
gocritic flagged the Deprecated notice on SetMiniServiceReadyStatus for not being in its own paragraph. Without the blank comment line, go vet and IDE tooling do not reliably recognize it as a deprecation notice, so callers would not get flagged. NO-REF Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
1 parent 89c6c67 commit 94f0263

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

  • src/compute-plane-services/nvca/internal/metrics

src/compute-plane-services/nvca/internal/metrics/metrics.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1063,6 +1063,7 @@ func (m *Metrics) RecordMiniServiceFailure(ncaID, reason string) {
10631063
}
10641064

10651065
// SetMiniServiceReadyStatus sets the ready status gauge for a MiniService.
1066+
//
10661067
// Deprecated: use RecordMiniServicePhaseTransition and RecordMiniServiceFailure instead.
10671068
func (m *Metrics) SetMiniServiceReadyStatus(ncaID string, value float64) {
10681069
if m == nil {

0 commit comments

Comments
 (0)