Skip to content

Commit fbb748e

Browse files
committed
docs(byoo): sync the README cache contract; bump VERSION
The README still described the genrule as using local = True and claimed remote-cache reuse via the decommissioned internal cache. Both are now wrong: the tags are no-sandbox + no-remote-exec, the action is cache-eligible, and the host Go toolchain is bound into the action key via --action_env so a compiler bump cannot serve stale binaries. VERSION 0.157.0 -> 0.157.1. The subtree has a gate requiring a VERSION bump whenever any file under it changes, and this PR necessarily changes otelcol/BUILD.bazel. Patch-level only, so the major/minor stays in lockstep with the collector version in otel-collector-build.yaml, which the gate also cross-checks. The produced binary is unchanged in content; only how it is built and cached changes. This also clears the last reference to the retired cache host, which #435 had to leave in place precisely because that PR could not justify a VERSION bump for a comment-only edit. Co-authored-by: Balaji Ganesan <bganesan@nvidia.com>
1 parent 317bf12 commit fbb748e

2 files changed

Lines changed: 11 additions & 5 deletions

File tree

‎src/compute-plane-services/byoo-otel-collector/README.md‎

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,17 @@ dep tracking for forward progress: the binary lives inside Bazel's
7272
output graph and flows through to `oci_image` + `oci_push` cleanly.
7373

7474
Cache contract: Bazel rebuilds the genrule when any input
75-
(`otelcol/**/*.go`, `go.mod`, `go.sum`) changes. The genrule uses
76-
`local = True` + `tags = ["no-sandbox"]` so it can resolve `go` from
77-
`$PATH` and write to the standard Go module cache. The wrapper
75+
(`otelcol/**/*.go`, `go.mod`, `go.sum`) changes. The genrule is tagged
76+
`no-sandbox` + `no-remote-exec` so it can resolve `go` from `$PATH` and
77+
write to the standard Go module cache, while remaining eligible for the
78+
build cache. It is deliberately not `local = True`: that tag also stops
79+
the result being reused from the disk or remote cache, which made the
80+
collector recompile on every CI run. Because the action shells out to a
81+
host `go` that Bazel does not track, CI binds the toolchain into the
82+
action key with `--action_env=BYOO_GO_TOOLCHAIN`, so a Go bump in the CI
83+
image cannot serve binaries built by the previous compiler. The wrapper
7884
binary, in contrast, is a regular `go_binary` and benefits from full
79-
Bazel hermeticity + nvcfbarn remote-cache reuse.
85+
Bazel hermeticity + remote-cache reuse.
8086

8187
A containerized Go application that provides a complete observability solution by orchestrating three functional components: it generates OpenTelemetry Collector configurations, extracts and manages secrets from ESS (Encrypted Secret Store), and runs a custom-built OpenTelemetry Collector binary.
8288

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0.157.0
1+
0.157.1

0 commit comments

Comments
 (0)