Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incremental builds do not work with patching framework #2498

Closed
jlowe opened this issue Oct 11, 2024 · 1 comment
Closed

[BUG] Incremental builds do not work with patching framework #2498

jlowe opened this issue Oct 11, 2024 · 1 comment
Labels
bug Something isn't working build

Comments

@jlowe
Copy link
Member

jlowe commented Oct 11, 2024

After #2497 incremental builds do not work properly. Trying to build the package target after the first time will fail because cudf source has already been patched. Specifying -Dsubmodule.patch.skip will get past this, but it will also skip building any of the C++ code, i.e.: anything under thirdparty/cudf/cpp/, thirdparty/java/src/main/native/, or src/main/cpp/. That means you end up running with old code which is quite confusing.

A workaround is to always build the clean package targets rather than just package, but that's significantly slower due to all the C++ dependencies being downloaded from scratch each time.

@jlowe jlowe added ? - Needs Triage bug Something isn't working build labels Oct 11, 2024
@sameerz
Copy link
Collaborator

sameerz commented Oct 15, 2024

Fixed by #2502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build
Projects
None yet
Development

No branches or pull requests

2 participants